From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [RFC PATCH v2 net-next 01/12] net: core: trivial
 netif_receive_skb_list() entry point
Date: Tue, 26 Jun 2018 17:06:34 -0700
Message-ID: <3fbb875b-c737-1b23-d56f-816e667e1e7f@gmail.com>
References: <fa3d7e58-e7b6-ad0c-619f-824c25ed0d97@solarflare.com>
 <55a58487-584a-9b1e-33d3-08e00af35bd8@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net
To: Edward Cree <ecree@solarflare.com>,
        linux-net-drivers@solarflare.com, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:45638 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754129AbeF0AGg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 26 Jun 2018 20:06:36 -0400
Received: by mail-pl0-f65.google.com with SMTP id bi1-v6so104216plb.12
        for <netdev@vger.kernel.org>; Tue, 26 Jun 2018 17:06:36 -0700 (PDT)
In-Reply-To: <55a58487-584a-9b1e-33d3-08e00af35bd8@solarflare.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/26/2018 11:17 AM, Edward Cree wrote:
> Just calls netif_receive_skb() in a loop.

...

> +void netif_receive_skb_list(struct sk_buff_head *list)


Please use a standard list_head and standard list operators.

(In all your patches)

1) We do not want to carry a spinlock_t + count per list...

2) We get nice debugging features with CONFIG_DEBUG_LIST=y

Note that we now have skb->list after 
commit d4546c2509b1e9cd082e3682dcec98472e37ee5a ("net: Convert GRO SKB handling to list_head.")

Thanks !