From: Daniel Borkmann <borkmann@iogearbox.net>
To: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org
Cc: joe@wand.net.nz, Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH] selftests/bpf: check return value of fopen in test_verifier.c
Date: Thu, 17 May 2018 22:37:20 +0200 [thread overview]
Message-ID: <3fbcc868-c494-270d-9fc9-ca1173c3b932@iogearbox.net> (raw)
In-Reply-To: <152657877097.9825.6742536221308880897.stgit@firesoul>
On 05/17/2018 07:39 PM, Jesper Dangaard Brouer wrote:
> Commit 0a6748740368 ("selftests/bpf: Only run tests if !bpf_disabled")
> forgot to check return value of fopen.
>
> This caused some confusion, when running test_verifier (from
> tools/testing/selftests/bpf/) on an older kernel (< v4.4) as it will
> simply seqfault.
>
> This fix avoids the segfault and prints an error, but allow program to
> continue. Given the sysctl was introduced in 1be7f75d1668 ("bpf:
> enable non-root eBPF programs"), we know that the running kernel
> cannot support unpriv, thus continue with unpriv_disabled = true.
>
> Fixes: 0a6748740368 ("selftests/bpf: Only run tests if !bpf_disabled")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Applied to bpf, thanks Jesper!
prev parent reply other threads:[~2018-05-17 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 17:39 [PATCH] selftests/bpf: check return value of fopen in test_verifier.c Jesper Dangaard Brouer
2018-05-17 20:37 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fbcc868-c494-270d-9fc9-ca1173c3b932@iogearbox.net \
--to=borkmann@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=brouer@redhat.com \
--cc=joe@wand.net.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox