From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net: metrics: add proper netlink validation Date: Mon, 4 Jun 2018 16:58:44 -0700 Message-ID: <3fe98bf1-ce7d-0d57-6a49-70efc34ac366@gmail.com> References: <20180604234601.261823-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev To: David Ahern , Eric Dumazet , "David S . Miller" Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:35712 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeFDX6q (ORCPT ); Mon, 4 Jun 2018 19:58:46 -0400 Received: by mail-pl0-f68.google.com with SMTP id i5-v6so329265plt.2 for ; Mon, 04 Jun 2018 16:58:45 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/04/2018 04:54 PM, David Ahern wrote: > On 6/4/18 4:46 PM, Eric Dumazet wrote: >> Before using nla_get_u32(), better make sure the attribute >> is of the proper size. >> >> Code recently was changed, but bug has been there from beginning >> of git. >> > ... >> >> Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file") > > That commit just moved the code from 1 file to another. The previous > commit id is 6cf9dfd3bd62e, but it just moved code to a helper. The > originating commit id for the ip_metrics_convert bug is: > Please read what I wrote. I simply wanted to warn stable teams that your this patch is based on recent tree, but bug has been there forever. The Fixes: tag might help them to cook proper backports, thats is all. A Fixes: tag does not blame the code, it simply gives some hints. > ea697639992d9 ("net: tcp: add RTAX_CC_ALGO fib handling") > This patch has not added any bug, it was there already. I can put a (long) list of tags, but ultimately the bug has been there forever.