From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [patch net-next RFC v2 04/11] devlink: Add relation between dpipe
 and resource
Date: Sat, 18 Nov 2017 12:06:54 -0700
Message-ID: <3ff0a823-4a41-14a0-bc34-7c19eb0103cd@cumulusnetworks.com>
References: <20171114161852.6633-1-jiri@resnulli.us>
 <20171114161852.6633-5-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, mlxsw@mellanox.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        michael.chan@broadcom.com, ganeshgr@chelsio.com,
        saeedm@mellanox.com, matanb@mellanox.com, leonro@mellanox.com,
        idosch@mellanox.com, jakub.kicinski@netronome.com, ast@kernel.org,
        daniel@iogearbox.net, simon.horman@netronome.com,
        pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com,
        alexander.h.duyck@intel.com, linville@tuxdriver.com,
        gospo@broadcom.com, steven.lin1@broadcom.com, yuvalm@mellanox.com,
        ogerlitz@mellanox.com, roopa@cumulusnetworks.com
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f194.google.com ([209.85.192.194]:43562 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754699AbdKRTG6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 18 Nov 2017 14:06:58 -0500
Received: by mail-pf0-f194.google.com with SMTP id b6so4310826pff.10
        for <netdev@vger.kernel.org>; Sat, 18 Nov 2017 11:06:58 -0800 (PST)
In-Reply-To: <20171114161852.6633-5-jiri@resnulli.us>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/14/17 9:18 AM, Jiri Pirko wrote:
> @@ -192,6 +194,8 @@ struct devlink_dpipe_table {
>  	const char *name;
>  	bool counters_enabled;
>  	bool counter_control_extern;
> +	u64 resource_id;
> +	bool resource_valid;

from a space perspective, please reverse the order

>  	struct devlink_dpipe_table_ops *table_ops;
>  	struct rcu_head rcu;
>  };
> @@ -387,6 +391,8 @@ void devlink_resources_unregister(struct devlink *devlink,
>  int devlink_resource_size_get(struct devlink *devlink,
>  			      u64 resource_id,
>  			      u64 *p_resource_size);
> +int devlink_dpipe_table_resource_set(struct devlink *devlink,
> +				     const char *table_name, u64 resource_id);
>  
>  #else
>  
> @@ -550,6 +556,13 @@ devlink_resource_size_get(struct devlink *devlink, u64 resource_id,
>  	return -EINVAL;
>  }
>  
> +static inline int
> +devlink_dpipe_table_resource_set(struct devlink *devlink,
> +				 const char *table_name, u64 resource_id)
> +{
> +	return -EINVAL;

It's compiled out so -EOPNOTSUPP seems more appropriate.