From: Jacob Keller <jacob.e.keller@intel.com>
To: Petr Oros <poros@redhat.com>,
Anthony Nguyen <anthony.l.nguyen@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] iavf: fix deadlock in reset handling
Date: Fri, 6 Feb 2026 17:00:51 -0800 [thread overview]
Message-ID: <3ff86f0d-4f22-4afa-b84e-3dbc6e9910d7@intel.com> (raw)
In-Reply-To: <20260206100426.106082-1-poros@redhat.com>
On 2/6/2026 2:04 AM, Petr Oros wrote:
> description...
>
> Fixes: 120f28a6f314 ("iavf: get rid of the crit lock")
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
Code changes look correct to me. Description obviously needs to get
written, but...
I loaded both the net as of ee9241524b46 ("amd-xgbe: do not select
NET_SELFTESTS when INET is disabled") and tested it with and without
this fix applied.
Before the fix, changing MTU till timeout after a few seconds with the
complaint, after which the reset will happen and MTU will be applied
late (the timeout in the wait event prevents a permanent deadlock). With
the fix the command completes quickly with no errors and the MTU change
applies immediately.
Tested-by: Jacob Keller <jacob.e.keller@intel.com>
Additionally, for a version with a proper commit message, please feel
free to add:
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Thanks for working on this, Petr!
Regards,
Jake
next prev parent reply other threads:[~2026-02-07 1:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 8:48 [PATCH net] iavf: fix deadlock in reset handling Petr Oros
2026-02-02 9:06 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-02-02 10:53 ` Jijie Shao
2026-02-02 13:30 ` Ivan Vecera
2026-02-02 23:58 ` Jakub Kicinski
2026-02-03 1:00 ` [Intel-wired-lan] " Jacob Keller
2026-02-03 8:44 ` Petr Oros
2026-02-03 10:19 ` Przemek Kitszel
2026-02-03 11:32 ` Petr Oros
2026-02-03 23:47 ` Jacob Keller
2026-02-04 6:12 ` Przemek Kitszel
2026-02-04 19:25 ` Jacob Keller
2026-02-05 12:24 ` Petr Oros
2026-02-05 23:37 ` Jacob Keller
2026-02-06 10:04 ` Petr Oros
2026-02-07 1:00 ` Jacob Keller [this message]
2026-02-07 3:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff86f0d-4f22-4afa-b84e-3dbc6e9910d7@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox