From: Davide Caratti <dcaratti@redhat.com>
To: Lucas Bates <lucasb@mojatatu.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
mleitner@redhat.com, vladbu@mellanox.com, kernel@mojatatu.com
Subject: Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc
Date: Tue, 25 Jun 2019 09:02:05 +0200 [thread overview]
Message-ID: <3ffd1c736a322ac36e0a5a88a1203e762529e7a3.camel@redhat.com> (raw)
In-Reply-To: <1561424427-9949-1-git-send-email-lucasb@mojatatu.com>
On Mon, 2019-06-24 at 21:00 -0400, Lucas Bates wrote:
> This patch restores the original behaviour for tdc prior to the
> introduction of the plugin system, where the network namespace
> functionality was split from the main script.
>
> It introduces the concept of required plugins for testcases,
> and will automatically load any plugin that isn't already
> enabled when said plugin is required by even one testcase.
>
> Additionally, the -n option for the nsPlugin is deprecated
> so the default action is to make use of the namespaces.
> Instead, we introduce -N to not use them, but still create
> the veth pair.
>
> buildebpfPlugin's -B option is also deprecated.
>
> If a test cases requires the features of a specific plugin
> in order to pass, it should instead include a new key/value
> pair describing plugin interactions:
>
> "plugins": {
> "requires": "buildebpfPlugin"
> },
>
> A test case can have more than one required plugin: a list
> can be inserted as the value for 'requires'.
>
> Signed-off-by: Lucas Bates <lucasb@mojatatu.com>
> ---
hi Lucas,
thanks a lot for including a fix for buildebpfPlugin!
Acked-by: Davide Caratti <dcaratti@redhat.com>
next prev parent reply other threads:[~2019-06-25 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 1:00 [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc Lucas Bates
2019-06-25 7:02 ` Davide Caratti [this message]
2019-06-25 8:49 ` Nicolas Dichtel
2019-06-25 19:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ffd1c736a322ac36e0a5a88a1203e762529e7a3.camel@redhat.com \
--to=dcaratti@redhat.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=lucasb@mojatatu.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).