netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: subashab@codeaurora.org
To: "Eric Dumazet" <eric.dumazet@gmail.com>
Cc: "Jesper Dangaard Brouer" <brouer@redhat.com>,
	netfilter-devel@vger.kernel.org, pablo@netfilter.org,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WARN due to local_bh_disable called with interrupts disabled
Date: Thu, 19 Nov 2015 22:19:21 -0000	[thread overview]
Message-ID: <3ffdb703b1c0b9011665e0d81e3e62c2.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1447936112.22599.197.camel@edumazet-glaptop2.roam.corp.google.com>

>>
>> The call gic_handle_irq() sounds like a hardware IRQ func/context.
>>
>> The flush_backlog() call is due to the device is being unregistered.
>>

Yes, this is the ARM interrupt controller. It appeared as if wifi was
getting torn down around this.

>> I'm surprised to see kfree_skb() being called from hardirq context, I
>> though that was not allowed.
>>
>> AFAIK this is the reason we have: __dev_kfree_skb_any() which defer
>> freeing the SKB if (in_irq() || irqs_disabled()).
>>
>> Code:
>>  void __dev_kfree_skb_any(struct sk_buff *skb, enum skb_free_reason
>> reason)
>>  {
>> 	if (in_irq() || irqs_disabled())
>> 		__dev_kfree_skb_irq(skb, reason);
>> 	else
>> 		dev_kfree_skb(skb);
>>  }
>
> Right, but flush_backlog() is processing packets coming from RX, that
> should have no conntracking attached at all.
>
> Might be a bug in a tunnel ?

Thanks Jesper \ Eric. I'll explore into why a conntrack entry is
associated with this skb.

      reply	other threads:[~2015-11-19 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <94ad7f112d565984ffdc4aaafe002803.squirrel@www.codeaurora.org>
2015-11-19 10:42 ` WARN due to local_bh_disable called with interrupts disabled Jesper Dangaard Brouer
2015-11-19 12:28   ` Eric Dumazet
2015-11-19 22:19     ` subashab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ffdb703b1c0b9011665e0d81e3e62c2.squirrel@www.codeaurora.org \
    --to=subashab@codeaurora.org \
    --cc=brouer@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).