From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next] net/ipv6: fix LOCKDEP issue in rt6_remove_exception_rt() Date: Tue, 24 Apr 2018 10:25:14 -0600 Message-ID: <400a8f3f-4ab7-527f-59ed-454d2da8e828@gmail.com> References: <20180424162249.41820-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev , Eric Dumazet To: Eric Dumazet , "David S . Miller" Return-path: Received: from mail-pf0-f176.google.com ([209.85.192.176]:34552 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbeDXQZQ (ORCPT ); Tue, 24 Apr 2018 12:25:16 -0400 Received: by mail-pf0-f176.google.com with SMTP id a14so2183289pfi.1 for ; Tue, 24 Apr 2018 09:25:16 -0700 (PDT) In-Reply-To: <20180424162249.41820-1-edumazet@google.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 4/24/18 10:22 AM, Eric Dumazet wrote: > rt6_remove_exception_rt() is called under rcu_read_lock() only. > > We lock rt6_exception_lock a bit later, so we do not hold > rt6_exception_lock yet. > > Fixes: 8a14e46f1402 ("net/ipv6: Fix missing rcu dereferences on from") > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Cc: David Ahern > --- > net/ipv6/route.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Acked-by: David Ahern Thanks, Eric.