netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Make xircom cardbus handle shared irq
@ 2004-01-23  0:49 Stephen Hemminger
  2004-01-24 21:07 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2004-01-23  0:49 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: tulip-users, netdev

Current driver doesn't do shared irq properly.  When testing on
a laptop here irq 3 get shared between pcmcia slot and tty/IRDA

diff -Nru a/drivers/net/tulip/xircom_cb.c b/drivers/net/tulip/xircom_cb.c
--- a/drivers/net/tulip/xircom_cb.c	Thu Jan 22 16:46:34 2004
+++ b/drivers/net/tulip/xircom_cb.c	Thu Jan 22 16:46:34 2004
@@ -342,6 +342,11 @@
 	printk("tx status 0x%08x 0x%08x \n",card->tx_buffer[0],card->tx_buffer[4]);
 	printk("rx status 0x%08x 0x%08x \n",card->rx_buffer[0],card->rx_buffer[4]);
 #endif	
+	/* Handle shared irq and hotplug */
+	if (status == 0 || status == 0xffffffff) {
+		spin_unlock(&card->lock);
+		return IRQ_NONE;
+	}
 
 	if (link_status_changed(card)) {
 		int newlink;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Make xircom cardbus handle shared irq
  2004-01-23  0:49 [PATCH] Make xircom cardbus handle shared irq Stephen Hemminger
@ 2004-01-24 21:07 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-01-24 21:07 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: tulip-users, netdev

applied to 2.4 and 2.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-24 21:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-23  0:49 [PATCH] Make xircom cardbus handle shared irq Stephen Hemminger
2004-01-24 21:07 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).