From: Jeff Garzik <jgarzik@pobox.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: netdev@oss.sgi.com, ogasawara@osdl.org
Subject: Re: [janitor] depca: release resources on errors
Date: Sun, 25 Jan 2004 23:25:14 -0500 [thread overview]
Message-ID: <401496AA.4000404@pobox.com> (raw)
In-Reply-To: <20040125193017.450d6ff8.rddunlap@osdl.org>
Randy.Dunlap wrote:
> On Sun, 25 Jan 2004 11:36:38 -0500 Jeff Garzik <jgarzik@pobox.com> wrote:
>
> | Most of these patches you're sending are already in netdev-2.6, AFAICS...
>
>
> net: remove unnecessary type casting -- not found in netdev
I applied this one
> tc35815: handle ioremap() failure -- still missed (*Leann)
dev->base_addr = (unsigned long)ioremap(base_addr,
sizeof(struct tc35815_regs));
if (!dev->base_addr) {
ret = -ENOMEM;
goto err_out;
}
> dgrs: add iounmap()s to failure paths -- still missed (*Leann)
this wants fixing as well
next prev parent reply other threads:[~2004-01-26 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-25 6:31 [janitor] depca: release resources on errors Randy.Dunlap
2004-01-25 16:36 ` Jeff Garzik
2004-01-26 3:30 ` Randy.Dunlap
2004-01-26 4:25 ` Jeff Garzik [this message]
2004-01-30 2:14 ` Leann Ogasawara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401496AA.4000404@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=ogasawara@osdl.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).