From: Jeff Garzik <jgarzik@pobox.com>
To: Kevin Curtis <kevin.curtis@farsite.co.uk>
Cc: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>,
"'davem@redhat.com'" <davem@redhat.com>
Subject: Re: Update FarSync WAN driver in 2.4.25
Date: Wed, 04 Feb 2004 16:18:03 -0500 [thread overview]
Message-ID: <4021618B.7070605@pobox.com> (raw)
In-Reply-To: <7C078C66B7752B438B88E11E5E20E72E25CBB5@general.hq.farsitecommunications.com>
Comments:
* please use standard indentation (one tab)
* please use constants per the include/linux/pci_ids.h standard, rather
than defining your own.
* please use standard include/linux/pci.h constants, rather than
defining your own (PCIILR, etc.)
* further, obtain interrupt from struct pci_dev::irq after calling
pci_enable_device(); do not obtain directly via pci_read_config_xxx()
* fst_process_rx_status() could result in flooding the log
* use pci_set_master() to enable bus-mastering
* bottom halves are deprecated. do not add new code using mark_bh() and
friends. Use tasklets or schedule_task().
* use pci_set_dma_mask() rather than pci_dma_supported()
* use pci_request_regions() rather than request_region()
next prev parent reply other threads:[~2004-02-04 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 16:06 Update FarSync WAN driver in 2.4.25 Kevin Curtis
2004-02-04 21:18 ` Jeff Garzik [this message]
2004-02-04 21:32 ` Francois Romieu
-- strict thread matches above, loose matches on Subject: below --
2004-02-12 10:12 Kevin Curtis
2004-04-26 16:33 Kevin Curtis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4021618B.7070605@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=kevin.curtis@farsite.co.uk \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).