From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467622592 for ; Sat, 15 Jul 2023 21:43:09 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ABA3213F; Sat, 15 Jul 2023 14:43:06 -0700 (PDT) Received: from i53875a6a.versanet.de ([83.135.90.106] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qKn1b-00035T-PU; Sat, 15 Jul 2023 23:41:59 +0200 From: Heiko Stuebner To: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Justin Chen , Al Cooper , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Ioana Ciornei , Yu Chen , Binghui Wang , Mauro Carvalho Chehab , Lubomir Rintel , Miquel Raynal , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Wolfgang Grandegger , Marc Kleine-Budde , Alban Bedel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Robert Marko , Luka Perkov , Sergio Paracuellos , Yoshihiro Shimoda , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , Kunihiko Hayashi , Masami Hiramatsu , Maxime Coquelin , Alexandre Torgue , Vincent Shih , Thierry Reding , Jonathan Hunter , JC Kuo , Rob Herring Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-can@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Subject: Re: [PATCH] phy: Explicitly include correct DT includes Date: Sat, 15 Jul 2023 23:41:56 +0200 Message-ID: <4021989.Mh6RI2rZIc@phil> In-Reply-To: <20230714174841.4061919-1-robh@kernel.org> References: <20230714174841.4061919-1-robh@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_HELO_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Am Freitag, 14. Juli 2023, 19:48:35 CEST schrieb Rob Herring: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > drivers/phy/rockchip/phy-rockchip-dphy-rx0.c | 1 - > drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 2 +- > drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 1 - > drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 3 ++- > drivers/phy/rockchip/phy-rockchip-snps-pcie3.c | 3 ++- Acked-by: Heiko Stuebner