From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0 Date: Sun, 22 Nov 2015 21:00:28 +0100 Message-ID: <4040597.3hXVb3XDMS@wuerfel> References: <1448178839-3541-1-git-send-email-mw@semihalf.com> <1448178839-3541-3-git-send-email-mw@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Marcin Wojtas , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com, andrew@lunn.ch, linux@arm.linux.org.uk, jason@lakedaemon.net, myair@marvell.com, jaz@semihalf.com, simon.guinot@sequanux.org, xswang@marvell.com, nadavh@marvell.com, alior@marvell.com, stable@vger.kernel.org, tn@semihalf.com, gregory.clement@free-electrons.com, nitroshift@yahoo.com, davem@davemloft.net, sebastian.hesselbarth@gmail.com To: linux-arm-kernel@lists.infradead.org Return-path: In-Reply-To: <1448178839-3541-3-git-send-email-mw@semihalf.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sunday 22 November 2015 08:53:48 Marcin Wojtas wrote: > The Ethernet controller found in the Armada 38x SoC's family support > TCP/IP checksumming with frame sizes larger than 1600 bytes, however > only on port 0. > > This commit enables this feature by using 'marvell,armada-xp-neta' in > 'ethernet@70000' node. > > Signed-off-by: Marcin Wojtas > Cc: # v3.18+ > --- > arch/arm/boot/dts/armada-38x.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > index c6a0e9d..b7868b2 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -494,7 +494,7 @@ > }; > > eth0: ethernet@70000 { > - compatible = "marvell,armada-370-neta"; > + compatible = "marvell,armada-xp-neta"; > reg = <0x70000 0x4000>; > interrupts-extended = <&mpic 8>; > clocks = <&gateclk 4>; > As it's clear that they are not 100% backwards compatible, please add a SoC specific compatible string here as well, like compatible = "marvell,armada-380-neta", "marvell,armada-xp-neta"; Maybe also leave the 370 string in place. Arnd