From: Paolo Abeni <pabeni@redhat.com>
To: chia-yu.chang@nokia-bell-labs.com, edumazet@google.com,
linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org,
dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com,
kuba@kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net,
liuhangbin@gmail.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Subject: Re: [PATCH v4 net-next 05/13] tcp: accecn: handle unexpected AccECN negotiation feedback
Date: Thu, 16 Oct 2025 11:02:22 +0200 [thread overview]
Message-ID: <4042d1da-a7aa-46c4-87c5-736d74d280a2@redhat.com> (raw)
In-Reply-To: <20251013170331.63539-6-chia-yu.chang@nokia-bell-labs.com>
On 10/13/25 7:03 PM, chia-yu.chang@nokia-bell-labs.com wrote:
> From: Chia-Yu Chang <chia-yu.chang@nokia-bell-labs.com>
>
> According to Section 3.1.2 of AccECN spec (RFC9768), if a TCP Client
> has sent a SYN requesting AccECN feedback with (AE,CWR,ECE) = (1,1,1)
> then receives a SYN/ACK with the currently reserved combination
> (AE,CWR,ECE) = (1,0,1) but it does not have logic specific to such a
> combination, the Client MUST enable AccECN mode as if the SYN/ACK
> confirmed that the Server supported AccECN and as if it fed back that
> the IP-ECN field on the SYN had arrived unchanged.
>
> This patch fix an incorrect AccECN negoation of commit 3cae34274c79
> ("tcp: accecn: AccECN negotiation").
Minor nit: with my previous feedback I asked a formal fixes tag here.
Yes, we can have fixes tag on net-next.
No need to re-submit just for this.
/P
next prev parent reply other threads:[~2025-10-16 9:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 17:03 [PATCH v4 net-next 00/13] AccECN protocol case handling series chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 01/13] tcp: try to avoid safer when ACKs are thinned chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 02/13] gro: flushing when CWR is set negatively affects AccECN chia-yu.chang
2025-10-16 9:17 ` Paolo Abeni
2025-10-16 20:26 ` Ilpo Järvinen
2025-10-20 15:26 ` Chia-Yu Chang (Nokia)
2025-10-20 15:31 ` Eric Dumazet
2025-10-20 16:46 ` Chia-Yu Chang (Nokia)
2025-10-13 17:03 ` [PATCH v4 net-next 03/13] tcp: L4S ECT(1) identifier and NEEDS_ACCECN for CC modules chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 04/13] tcp: disable RFC3168 fallback identifier " chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 05/13] tcp: accecn: handle unexpected AccECN negotiation feedback chia-yu.chang
2025-10-16 9:02 ` Paolo Abeni [this message]
2025-10-13 17:03 ` [PATCH v4 net-next 06/13] tcp: accecn: retransmit downgraded SYN in AccECN negotiation chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 07/13] tcp: move increment of num_retrans chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 08/13] tcp: accecn: retransmit SYN/ACK without AccECN option or non-AccECN SYN/ACK chia-yu.chang
2025-10-16 9:13 ` Paolo Abeni
2025-10-18 16:06 ` Chia-Yu Chang (Nokia)
2025-10-13 17:03 ` [PATCH v4 net-next 09/13] tcp: accecn: unset ECT if receive or send ACE=0 in AccECN negotiaion chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 10/13] tcp: accecn: fallback outgoing half link to non-AccECN chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 11/13] tcp: accecn: verify ACE counter in 1st ACK after AccECN negotiation chia-yu.chang
2025-10-13 17:03 ` [PATCH v4 net-next 12/13] tcp: accecn: detect loss ACK w/ AccECN option and add TCP_ACCECN_OPTION_PERSIST chia-yu.chang
2025-10-16 9:25 ` Paolo Abeni
2025-10-13 17:03 ` [PATCH v4 net-next 13/13] tcp: accecn: enable AccECN chia-yu.chang
2025-10-16 10:08 ` [PATCH v4 net-next 00/13] AccECN protocol case handling series Jakub Sitnicki
-- strict thread matches above, loose matches on Subject: below --
2025-10-10 13:17 chia-yu.chang
2025-10-10 13:17 ` [PATCH v4 net-next 05/13] tcp: accecn: handle unexpected AccECN negotiation feedback chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4042d1da-a7aa-46c4-87c5-736d74d280a2@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).