From: Jeff Garzik <jgarzik@pobox.com>
To: Don Fry <brazilnut@us.ibm.com>
Cc: tsbogend@alpha.franken.de, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.4-rc2-bk4 2/2] pcnet32 use netif_msg_init
Date: Mon, 08 Mar 2004 21:19:35 -0500 [thread overview]
Message-ID: <404D29B7.6070005@pobox.com> (raw)
In-Reply-To: <200403081946.i28Jkrb10646@DYN318364BLD.beaverton.ibm.com>
Don Fry wrote:
> @@ -2013,8 +2016,7 @@
> {
> printk(KERN_INFO "%s", version);
>
> - if (debug >= 0 && debug < (sizeof(int) - 1))
> - pcnet32_debug = 1 << debug;
> + pcnet32_debug = netif_msg_init(debug, 0);
Do you really want to default to silence? IMO define a
PCNET32_DEF_MSG_ENABLE with a few of the critical bits like probe-time
information.
Jeff
prev parent reply other threads:[~2004-03-09 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 19:46 [PATCH 2.6.4-rc2-bk4 2/2] pcnet32 use netif_msg_init Don Fry
2004-03-09 2:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404D29B7.6070005@pobox.com \
--to=jgarzik@pobox.com \
--cc=brazilnut@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).