2.6.4-rc1 + hp100 EISA, not working

2.6.4-rc1 + hp100 EISA, not working

[Paweł Sokołowski]

Hi.

I have HP 10/100VG AnyLan EISA card. My machine is a HP Netserver
4d/66LE. 486, EISA only.

After latest changes in hp100 driver, it stopped working for me.

It oopsed as module on 2.6.2 (and I experienced kernel panic when hp100
was build in) but after Oops I was able to get interface up and working:

hp100: eth0: HP J2577 at 0x2c38, IRQ 5, EISA bus, 128k SRAM (rx/tx 75%).
hp100: eth0: Memory area at 0xd0000-0xd3fff (virtual base c00d0000).
hp100: eth0: Adapter is attached to 10Mb/s network (10baseT).


On 2.6.3 it just Oopsed and didn't work. On 2.6.4-rc1 it does
not oops but it doesn't work (neither as module nor as build in kernel).
Module loads cleanly but does nothing - I can't get interface up,
nothing in dmesg.

If you need more details, logs etc., please tell me what you need to
know.



I don't know if it's related to this problem but at earlier stage of
booting I'm getting following messages:

EISA: Probing bus 0 at eisa0
EISA: Mainboard HWPC061 detected.
EISA: slot 2 : HWP1940 detected (disabled).
EISA: Detected 1 card.

Card works fine on 2.4.* (tested on 2.4.16, 2.4.24,25,26-pre1) :
hp100: eth0: HP J2577 at 0x2c38, IRQ 5, EISA bus, 128k SRAM (rx/tx 75%%).
hp100: eth0: Memory area at 0xd0000-0xd3fff (virtual base c00d0000).
hp100: eth0: Adapter is attached to 10Mb/s network.


-- 
  ,d$$$$$P.d$$b     d$P  ,gd$$$$$,gd$$$$g. ,$$$b._$$P               RLU #172534
  ggggggggggggg.   ggs  ,gg     ,gg    ,gg ggp,ggggg           Paweł Sokołowski
 d$P""""'""""Y$$. d$P   d$P     d$P   ,d$Pd$P `Y$$P      falcon@muflon.linux.pl
d$P           Y$$d$$$$$P`Y$$$$$'`Y$$$$$P'd$P   d$P    Replicant (M) Des: Falcon

Re: 2.6.4-rc1 + hp100 EISA, not working

[Marc Zyngier]

>>>>> "Pawel" == Pawe  <Pawe> writes:

Pawel> I don't know if it's related to this problem but at earlier stage of
Pawel> booting I'm getting following messages:

Pawel> EISA: Probing bus 0 at eisa0
Pawel> EISA: Mainboard HWPC061 detected.
Pawel> EISA: slot 2 : HWP1940 detected (disabled).
Pawel> EISA: Detected 1 card.

Try passing 'eisa_bus.enable_dev=2' to your kernel parameters. Your
card is tagged as unconfigured by BIOS, and thus is skipped by the
probing logic. See Documentation/eisa.txt for details.

	M.
-- 
Places change, faces change. Life is so very strange.

Re: 2.6.4-rc1 + hp100 EISA, not working

[Marc Zyngier]

>>>>> "Pawel" == Pawe  <Pawe> writes:

Pawel> On 2.6.3 it just Oopsed and didn't work. On 2.6.4-rc1 it does
Pawel> not oops but it doesn't work (neither as module nor as build in kernel).

Note that hp100 in 2.6.4-rc1 is still broken wrt EISA probing, since
it lacks the terminating entry in the EISA ID list. This one-liner
should take care of random crashes that are often reported to LKML :

===== drivers/net/hp100.c 1.24 vs edited =====
--- 1.24/drivers/net/hp100.c	Wed Feb 18 13:39:41 2004
+++ edited/drivers/net/hp100.c	Mon Mar  1 11:18:00 2004
@@ -201,6 +201,7 @@
 	{ "HWP1990" }, /* HP J2577 */
 	{ "CPX0301" }, /* ReadyLink ENET100-VG4 */
 	{ "CPX0401" }, /* FreedomLine 100/VG */
+	{ "" }	       /* Mandatory final entry ! */
 };
 MODULE_DEVICE_TABLE(eisa, hp100_eisa_tbl);
 #endif

Jeff, would you please push this to Linus ?

      M.
-- 
Places change, faces change. Life is so very strange.

Re: 2.6.4-rc1 + hp100 EISA, not working

[Jeff Garzik]

applied

Re: 2.6.4-rc1 + hp100 EISA, not working

[Pawel Sokolowski]

I've seen things you people wouldn't believe. You writing:

>Pawel> I don't know if it's related to this problem but at earlier stage of
>Pawel> booting I'm getting following messages:
>Pawel> EISA: Probing bus 0 at eisa0
>Pawel> EISA: Mainboard HWPC061 detected.
>Pawel> EISA: slot 2 : HWP1940 detected (disabled).
>Pawel> EISA: Detected 1 card.
>Try passing 'eisa_bus.enable_dev=2' to your kernel parameters. Your
>card is tagged as unconfigured by BIOS, and thus is skipped by the
>probing logic. See Documentation/eisa.txt for details.

This machine has RAM BIOS booted from floppy. I ran it and EISA
configure utility to check this once more. Card is enabled and not
locked. I added eisa_bus.enable_dev=2 parameter but it didn't help much.
I'm getting:

EISA: Probing bus 0 at eisa0
EISA: Mainboard HWPC061 detected.
EISA: slot 2 : HWP1940 detected (forced enabled).
EISA: Detected 1 card.

I added this final entry you mailed but nothing changed. Still - module
loads and unloads cleanly and without any warnings on 2.6.4-rc1. But
does nothing - not a single line in logs/dmesg after it's loaded. Card
does not work after modprobe, I can't get interface up.


If you need more details or some config files, please, let me know.

-- 
  ,d$$$$$P.d$$b     d$P  ,gd$$$$$,gd$$$$g. ,$$$b._$$P               RLU #172534
  ggggggggggggg.   ggs  ,gg     ,gg    ,gg ggp,ggggg           Paweł Sokołowski
 d$P""""'""""Y$$. d$P   d$P     d$P   ,d$Pd$P `Y$$P      falcon@muflon.linux.pl
d$P           Y$$d$$$$$P`Y$$$$$'`Y$$$$$P'd$P   d$P    Replicant (M) Des: Falcon

Re: 2.6.4-rc1 + hp100 EISA, not working

[Pawel Sokolowski]

I've seen things you people wouldn't believe. You writing:
>> Pawel> On 2.6.3 it just Oopsed and didn't work. On 2.6.4-rc1 it does
>> Pawel> not oops but it doesn't work (neither as module nor as build in kernel).
>> Note that hp100 in 2.6.4-rc1 is still broken wrt EISA probing, since
>> it lacks the terminating entry in the EISA ID list. This one-liner
>> should take care of random crashes that are often reported to LKML :
>>
>> ===== drivers/net/hp100.c 1.24 vs edited =====
>> --- 1.24/drivers/net/hp100.c	Wed Feb 18 13:39:41 2004
>> +++ edited/drivers/net/hp100.c	Mon Mar  1 11:18:00 2004
>> @@ -201,6 +201,7 @@
>>  	{ "HWP1990" }, /* HP J2577 */
>>  	{ "CPX0301" }, /* ReadyLink ENET100-VG4 */
>>  	{ "CPX0401" }, /* FreedomLine 100/VG */
>> +	{ "" }	       /* Mandatory final entry ! */
>>  };
>>  MODULE_DEVICE_TABLE(eisa, hp100_eisa_tbl);
>>  #endif
>
>It could be that there is a typo in the hp100 eisa device list, the following
>
>--- linux-2.6/drivers/eisa/eisa-bus.c	2004-01-23 09:38:19.000000000 -0800
>+++ tcp-2.6/drivers/eisa/eisa-bus.c	2004-03-03 12:23:53.604252800 -0800
[...]
>+	printk(KERN_DEBUG "eisa_bus_match dev sig='%s' state=0x%x eids=%s\n",
>+	       edev->id.sig, edev->state, eids ? eids->sig : "<null>");

With eisa_bus.enable_dev=2 I'm getting:

eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
eisa_bus_match dev sig='HWP1940' state=0x3 eids=HWPF180

without:

eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
eisa_bus_match dev sig='HWP1940' state=0x0 eids=HWPF180

when modprobing hp100.

-- 
  ,d$$$$$P.d$$b     d$P  ,gd$$$$$,gd$$$$g. ,$$$b._$$P               RLU #172534
  ggggggggggggg.   ggs  ,gg     ,gg    ,gg ggp,ggggg           Paweł Sokołowski
 d$P""""'""""Y$$. d$P   d$P     d$P   ,d$Pd$P `Y$$P      falcon@muflon.linux.pl
d$P           Y$$d$$$$$P`Y$$$$$'`Y$$$$$P'd$P   d$P    Replicant (M) Des: Falcon

Re: 2.6.4-rc1 + hp100 EISA, not working

[Stephen Hemminger]

 
> eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
> eisa_bus_match dev sig='HWP1940' state=0x3 eids=HWPF180
> 
> without:
> 
> eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
> eisa_bus_match dev sig='HWP1940' state=0x0 eids=HWPF180
> 
> when modprobing hp100.

The name HWP1940 is in the table, so that looks okay.
Can you build with HP100_DEBUG defined?

Re: 2.6.4-rc1 + hp100 EISA, not working

[Paweł Sokołowski]

I've seen things you people wouldn't believe. You writing:

>> eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
>> eisa_bus_match dev sig='HWP1940' state=0x3 eids=HWPF180
>> without:
>> eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
>> eisa_bus_match dev sig='HWP1940' state=0x0 eids=HWPF180
>> when modprobing hp100.
>The name HWP1940 is in the table, so that looks okay.
>Can you build with HP100_DEBUG defined?

OK. I builded module from 2.6.4-rc2 with HP100_DEBUG defined.

During compilation:

drivers/net/hp100.c: In function `hp100_eisa_probe':
drivers/net/hp100.c:2875: warning: unsigned int format, long unsigned int arg (arg 3)
drivers/net/hp100.c: In function `hp100_module_init':
drivers/net/hp100.c:3066: warning: label `out3' defined but not used
drivers/net/hp100.c: At top level:
drivers/net/hp100.c:2806: warning: `hp100_RegisterDump' defined but not used

after modprobe hp100 I'm getting just:

bus eisa: add driver hp100

nothing more (I added CONFIG_DEBUG_DRIVER to kernel config).

The same on 2.6.4-rc1 (without any message after loading module).

-- 
  ,d$$$$$P.d$$b     d$P  ,gd$$$$$,gd$$$$g. ,$$$b._$$P               RLU #172534
  ggggggggggggg.   ggs  ,gg     ,gg    ,gg ggp,ggggg           Paweł Sokołowski
 d$P""""'""""Y$$. d$P   d$P     d$P   ,d$Pd$P `Y$$P      falcon@muflon.linux.pl
d$P           Y$$d$$$$$P`Y$$$$$'`Y$$$$$P'd$P   d$P    Replicant (M) Des: Falcon

Re: 2.6.4-rc1 + hp100 EISA, not working

[Marc Zyngier]

>>>>> "Pawel" == Pawel Sokolowski <falcon@muflon.linux.pl> writes:

Pawel> This machine has RAM BIOS booted from floppy. I ran it and EISA
Pawel> configure utility to check this once more. Card is enabled and not
Pawel> locked. I added eisa_bus.enable_dev=2 parameter but it didn't help much.
Pawel> I'm getting:

Pawel> EISA: Probing bus 0 at eisa0
Pawel> EISA: Mainboard HWPC061 detected.
Pawel> EISA: slot 2 : HWP1940 detected (forced enabled).
Pawel> EISA: Detected 1 card.

Pawel> I added this final entry you mailed but nothing changed. Still - module
Pawel> loads and unloads cleanly and without any warnings on 2.6.4-rc1. But
Pawel> does nothing - not a single line in logs/dmesg after it's loaded. Card
Pawel> does not work after modprobe, I can't get interface up.

Ok, found it.

It really looks like the new EISA probing code in hp100 never got
tested, since a precious offset has disappeared during the rewriting
process.

Please note that you still need to enable the device by hand, since
your BIOS (or maybe the EISA CFG file, since I'm seeing the exact same
problem on a Compaq machine here) doesn't properly enable the card.

Here is what I'm getting on my test system :

EISA: Probing bus 0 at 0000:00:0f.0
EISA: Mainboard CPQ0541 detected.
EISA: slot 1 : DEC4250 detected.
EISA: slot 2 : UNB0048 detected.
EISA: slot 3 : HWP1940 detected (forced enabled).
hp100: Using (slow) programmed i/o mode.
hp100: at 0x3c38, IRQ 3, EISA bus, 128k SRAM (rx/tx 75%).
hp100: Adapter is attached to 10Mb/s network (10baseT).
EISA: slot 4 : NVL0701 detected.

Jeff, please apply.

	M.

===== drivers/net/hp100.c 1.26 vs edited =====
--- 1.26/drivers/net/hp100.c	Mon Mar  1 12:18:00 2004
+++ edited/drivers/net/hp100.c	Mon Mar  8 22:42:53 2004
@@ -2862,7 +2862,7 @@
 	SET_MODULE_OWNER(dev);
 	SET_NETDEV_DEV(dev, &edev->dev);
 
-	err = hp100_probe1(dev, edev->base_addr, HP100_BUS_EISA, NULL);
+	err = hp100_probe1(dev, edev->base_addr + 0xC38, HP100_BUS_EISA, NULL);
 	if (err)
 		goto out1;
 

-- 
Places change, faces change. Life is so very strange.

Re: 2.6.4-rc1 + hp100 EISA, not working

[Jeff Garzik]

applied