Jeff Garzik wrote: > ===== drivers/net/s2io.h 1.1 vs 1.2 ===== > --- 1.1/drivers/net/s2io.h Sat Mar 20 04:38:16 2004 > +++ 1.2/drivers/net/s2io.h Sat Mar 20 04:47:53 2004 > @@ -14,8 +14,8 @@ > #define _S2IO_H > > #define TBD 0 > -#define BIT(loc) (((u64)0x8000000000000000ULL) >> loc) > -#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz)) > +#define BIT(loc) (1ULL << (loc)) > +#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz)) and here is a patch correcting an incorrect cleanup...