From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] [RFT] 2.6.4 - epic100 napi
Date: Sun, 21 Mar 2004 13:24:06 -0500 [thread overview]
Message-ID: <405DDDC6.7030007@pobox.com> (raw)
In-Reply-To: <20040320152109.A31118@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> People are welcome to report how the following patch behaves on their
> hardware. It does not seem too bad here but it probably is still a bit rough.
> A split version of the patch will follow tomorrow. This one definitely aims
> at brave and/or bored testers.
Looks pretty good, but includes a standard NAPI race...
When you split up the patches, I'll throw it into my -netdev tree, which
means it will be automatically included in -mm for testing (as is r8169
now).
FWIW Andrew Morton has made me lazy... I don't bother publishing
separate -netdev patches anymore, since he automatically downloads my
netdev-2.6 BK tree before doing each -mm release.
> + if (work_done < orig_budget) {
> + unsigned long flags;
> + int status;
> +
> + spin_lock_irqsave(&ep->napi_lock, flags);
> + epic_napi_irq_on(dev, ep);
> + __netif_rx_complete(dev);
> + spin_unlock_irqrestore(&ep->napi_lock, flags);
> +
> + status = inl(ioaddr + INTSTAT);
> + if (status & EpicNapiEvent) {
> + epic_napi_irq_off(dev, ep);
> + goto rx_action;
> + }
Need to add a netif_running() check to the 'if' test at the top of the
quote.
Are you (or somebody else?) interested in reviewing all the in-tree NAPI
drivers, and seeing if other drivers have this bug? I think 8139cp.c
does at least, maybe e100 too... Such a fix would need to go into 2.4.x
as well.
Jeff
next prev parent reply other threads:[~2004-03-21 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 14:21 [PATCH] [RFT] 2.6.4 - epic100 napi Francois Romieu
2004-03-21 18:24 ` Jeff Garzik [this message]
2004-03-21 23:47 ` Francois Romieu
2004-03-23 14:29 ` OGAWA Hirofumi
2004-03-23 15:14 ` Jeff Garzik
2004-03-23 16:05 ` OGAWA Hirofumi
2004-03-23 18:51 ` Francois Romieu
2004-03-23 19:59 ` OGAWA Hirofumi
2004-03-24 0:41 ` Francois Romieu
2004-03-24 2:52 ` OGAWA Hirofumi
2004-03-24 12:33 ` Francois Romieu
2004-03-25 0:27 ` [PATCH] 2.6.5-rc2 - more " Francois Romieu
2004-03-22 23:50 ` [PATCH 0/4] 2.6.5-rc2 - epic100 update Francois Romieu
2004-03-22 23:51 ` [PATCH 1/4] 2.6.5-rc2 - epic100 fixup Francois Romieu
2004-03-22 23:52 ` [PATCH 2/4] 2.6.5-rc2 - epic100 napi Francois Romieu
2004-03-22 23:53 ` [PATCH 3/4] " Francois Romieu
2004-03-22 23:53 ` [PATCH 4/4] " Francois Romieu
2004-03-23 0:12 ` [PATCH 0/4] 2.6.5-rc2 - epic100 update Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405DDDC6.7030007@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).