From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Kedareswara rao Appana <appana.durga.rao@xilinx.com>,
anirudh@xilinx.com, wg@grandegger.com, mkl@pengutronix.de,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
appanad@xilinx.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org
Subject: Re: [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite
Date: Thu, 22 Oct 2015 10:14:30 +0200 [thread overview]
Message-ID: <4061693.oBld7AKBIp@wuerfel> (raw)
In-Reply-To: <1445489163-11045-1-git-send-email-appanad@xilinx.com>
On Thursday 22 October 2015 10:16:02 Kedareswara rao Appana wrote:
> The driver only supports memory-mapped I/O [by ioremap()],
> so readl/writel is actually the right thing to do, IMO.
> During the validation of this driver or IP on ARM 64-bit processor
> while sending lot of packets observed that the tx packet drop with iowrite
> Putting the barriers for each tx fifo register write fixes this issue
> Instead of barriers using writel also fixed this issue.
>
> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com>
The two should really do the same thing: iowrite32() is just a static inline
calling writel() on both ARM32 and ARM64. On which kernel version did you
observe the difference? It's possible that an older version used
CONFIG_GENERIC_IOMAP, which made this slightly more expensive.
If there are barriers that you want to get rid of for performance reasons,
you should use writel_relaxed(), but be careful to synchronize them correctly
with regard to DMA. It should be fine in this driver, as it does not
perform any DMA, but be aware that there is no big-endian version of
writel_relaxed() at the moment.
Arnd
next prev parent reply other threads:[~2015-10-22 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 4:46 [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite Kedareswara rao Appana
2015-10-22 4:46 ` [PATCH 2/2] can: xilinx: fix bug in bus error handling Kedareswara rao Appana
2015-10-22 4:46 ` Kedareswara rao Appana
2015-10-22 4:46 ` Kedareswara rao Appana
2015-10-22 8:14 ` Arnd Bergmann [this message]
2015-10-22 8:21 ` [PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite Marc Kleine-Budde
2015-10-22 8:39 ` Appana Durga Kedareswara Rao
2015-10-22 8:58 ` Arnd Bergmann
2015-10-25 20:32 ` Marc Kleine-Budde
2015-10-26 1:25 ` Arnd Bergmann
2015-10-22 8:34 ` Appana Durga Kedareswara Rao
2015-10-22 9:02 ` Arnd Bergmann
2015-10-22 9:49 ` Michal Simek
[not found] ` <1445489163-11045-2-git-send-email-appanad@xilinx.com>
2015-10-22 16:33 ` [PATCH 2/2] can: xilinx: fix bug in bus error handling Sören Brinkmann
2015-10-23 5:21 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4061693.oBld7AKBIp@wuerfel \
--to=arnd@arndb.de \
--cc=anirudh@xilinx.com \
--cc=appana.durga.rao@xilinx.com \
--cc=appanad@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).