* linux/802_11.h header
@ 2004-03-30 20:28 Pavel Roskin
2004-03-30 21:51 ` Jean Tourrilhes
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Roskin @ 2004-03-30 20:28 UTC (permalink / raw)
To: netdev; +Cc: Jean Tourrilhes
Hello!
I see that include/linux/802_11.h in Linux 2.6.5-rc2-bk9 is included by
only one file, namely drivers/net/wireless/atmel_cs.c. In fact,
atmel_cs.c doesn't need it (tested by compiling it).
The 802_11.h header contains some definitions already present in
drivers/net/wireless/ieee802_11.h, which is used by some drivers. For
instance, frame subtypes are listed in both.
802_11.h also has useful definitions that should be elsewhere, such as
ieee_802_3_header and ieee_802_11_802_2_header. I was tempted to use some
definitions from 802_11.h, but then realized that it may be deprecated if
nobody is using it.
Does anybody know who wrote 802_11.h, whether it's deprecated, and if not,
why it's not used?
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux/802_11.h header
2004-03-30 20:28 linux/802_11.h header Pavel Roskin
@ 2004-03-30 21:51 ` Jean Tourrilhes
2004-03-30 23:23 ` Pavel Roskin
0 siblings, 1 reply; 6+ messages in thread
From: Jean Tourrilhes @ 2004-03-30 21:51 UTC (permalink / raw)
To: Pavel Roskin; +Cc: netdev
On Tue, Mar 30, 2004 at 03:28:58PM -0500, Pavel Roskin wrote:
> Hello!
>
> I see that include/linux/802_11.h in Linux 2.6.5-rc2-bk9 is included by
> only one file, namely drivers/net/wireless/atmel_cs.c. In fact,
> atmel_cs.c doesn't need it (tested by compiling it).
>
> The 802_11.h header contains some definitions already present in
> drivers/net/wireless/ieee802_11.h, which is used by some drivers. For
> instance, frame subtypes are listed in both.
>
> 802_11.h also has useful definitions that should be elsewhere, such as
> ieee_802_3_header and ieee_802_11_802_2_header. I was tempted to use some
> definitions from 802_11.h, but then realized that it may be deprecated if
> nobody is using it.
>
> Does anybody know who wrote 802_11.h, whether it's deprecated, and if not,
> why it's not used?
>
> --
> Regards,
> Pavel Roskin
Pavel,
Why don't you ask Simon directly ?
Have fun...
Jean
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux/802_11.h header
2004-03-30 21:51 ` Jean Tourrilhes
@ 2004-03-30 23:23 ` Pavel Roskin
2004-03-30 23:39 ` Jean Tourrilhes
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Roskin @ 2004-03-30 23:23 UTC (permalink / raw)
To: jt; +Cc: netdev
On Tue, 30 Mar 2004, Jean Tourrilhes wrote:
> > Does anybody know who wrote 802_11.h, whether it's deprecated, and if not,
> > why it's not used?
>
> Why don't you ask Simon directly ?
Because my question is not why atmel_cs uses a header it doesn't need
(the answer would be likely "oops" or "just in case").
My question is why we have two headers for the same purpose in the kernel
and what are we going to do with the header that is not used.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux/802_11.h header
2004-03-30 23:23 ` Pavel Roskin
@ 2004-03-30 23:39 ` Jean Tourrilhes
2004-03-31 0:15 ` Pavel Roskin
0 siblings, 1 reply; 6+ messages in thread
From: Jean Tourrilhes @ 2004-03-30 23:39 UTC (permalink / raw)
To: Pavel Roskin; +Cc: netdev
On Tue, Mar 30, 2004 at 06:23:46PM -0500, Pavel Roskin wrote:
> On Tue, 30 Mar 2004, Jean Tourrilhes wrote:
>
> > > Does anybody know who wrote 802_11.h, whether it's deprecated, and if not,
> > > why it's not used?
> >
> > Why don't you ask Simon directly ?
>
> Because my question is not why atmel_cs uses a header it doesn't need
> (the answer would be likely "oops" or "just in case").
>
> My question is why we have two headers for the same purpose in the kernel
> and what are we going to do with the header that is not used.
At some point, we had the headers of the old aironet4500
driver which looked like this one, but I don't think this driver was
ever moved to the wireless directory, so this is why I think this file
was added with the Atmel driver.
> Pavel Roskin
Jean
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux/802_11.h header
2004-03-30 23:39 ` Jean Tourrilhes
@ 2004-03-31 0:15 ` Pavel Roskin
2004-03-31 0:18 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Roskin @ 2004-03-31 0:15 UTC (permalink / raw)
To: jt; +Cc: netdev
On Tue, 30 Mar 2004, Jean Tourrilhes wrote:
> > Because my question is not why atmel_cs uses a header it doesn't need
> > (the answer would be likely "oops" or "just in case").
> >
> > My question is why we have two headers for the same purpose in the
> > kernel and what are we going to do with the header that is not used.
>
> At some point, we had the headers of the old aironet4500 driver
> which looked like this one, but I don't think this driver was ever moved
> to the wireless directory, so this is why I think this file was added
> with the Atmel driver.
Right. aironet4500 included linux/802_11.h. Since aironet4500 was
removed in 2.6 kernels, linux/802_11.h should also be removed. I really
don't want anybody to find this file and use definitions from it rather
than from ieee802_11.h.
The patch has been sent to Simon.
By the way, ieee802_11.h could be "promoted" to include/linux or
include/net with trivial changes to the drivers that use it.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-03-31 0:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-30 20:28 linux/802_11.h header Pavel Roskin
2004-03-30 21:51 ` Jean Tourrilhes
2004-03-30 23:23 ` Pavel Roskin
2004-03-30 23:39 ` Jean Tourrilhes
2004-03-31 0:15 ` Pavel Roskin
2004-03-31 0:18 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).