From: Nivedita Singhvi <niv@us.ibm.com>
To: davem@redhat.com
Cc: netdev <netdev@oss.sgi.com>
Subject: [PATCH 2.6] reference count cleanup continued -IPv6
Date: Wed, 31 Mar 2004 07:33:00 -0800 [thread overview]
Message-ID: <406AE4AC.6020309@us.ibm.com> (raw)
Continuing the reference count clean up, this time
in tcp_v6_rcv(). We should not be doing a sock_put()
on a socket in TIMEWAIT state.
Applies to 2.6.4. Should apply to current bits as
well.
thanks,
Nivedita
diff -urN linux-2.6.4/net/ipv6/tcp_ipv6.c linux-2.6.4mc6/net/ipv6/tcp_ipv6.c
--- linux-2.6.4/net/ipv6/tcp_ipv6.c 2004-03-10 18:55:28.000000000 -0800
+++ linux-2.6.4mc6/net/ipv6/tcp_ipv6.c 2004-03-30 10:34:25.000000000 -0800
@@ -1639,7 +1639,7 @@
no_tcp_socket:
if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb))
- goto discard_and_relse;
+ goto discard_it;
if (skb->len < (th->doff<<2) || tcp_checksum_complete(skb)) {
bad_packet:
@@ -1662,12 +1662,14 @@
goto discard_it;
do_time_wait:
- if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb))
- goto discard_and_relse;
+ if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) {
+ tcp_tw_put((struct tcp_tw_bucket *) sk);
+ goto discard_it;
+ }
if (skb->len < (th->doff<<2) || tcp_checksum_complete(skb)) {
TCP_INC_STATS_BH(TcpInErrs);
- sock_put(sk);
+ tcp_tw_put((struct tcp_tw_bucket *) sk);
goto discard_it;
}
next reply other threads:[~2004-03-31 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-31 15:33 Nivedita Singhvi [this message]
2004-04-01 7:12 ` [PATCH 2.6] reference count cleanup continued -IPv6 David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406AE4AC.6020309@us.ibm.com \
--to=niv@us.ibm.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).