From: Ben Greear <greearb@candelatech.com>
To: Andi Kleen <ak@muc.de>
Cc: Ville Nuorvala <vnuorval@tcs.hut.fi>, netdev@oss.sgi.com
Subject: Re: [PATCH] Avoid gettimeofday when not needed
Date: Wed, 31 Mar 2004 09:30:02 -0800 [thread overview]
Message-ID: <406B001A.1030901@candelatech.com> (raw)
In-Reply-To: <20040331151047.GA6033@colin2.muc.de>
Andi Kleen wrote:
> On Wed, Mar 31, 2004 at 05:24:47PM +0300, Ville Nuorvala wrote:
>
>>There just doesn't seem to be any general flag field in sk_buff that we
>>might use at this moment. Should one be added, or should we just hide the
>>flag inside the cb field using the likes of inet_skb_parm and
>>inet6_skb_parm?
>
>
> There are no free bits indeed. I think ->cb is the best choice then.
Why not add a 32-bit field to the skb to handle various flag needs
going forward?
If space is very important, could use an uint16 for flags and consolidate
the ip_summed and cloned fields, which seem to be boolean fields.
unsigned char local_df,
cloned,
pkt_type,
ip_summed;
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2004-03-31 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-31 12:01 [PATCH] Avoid gettimeofday when not needed Andi Kleen
2004-03-31 12:22 ` P
2004-03-31 13:53 ` Andi Kleen
2004-03-31 13:45 ` Ville Nuorvala
2004-03-31 13:54 ` Andi Kleen
2004-03-31 14:24 ` Ville Nuorvala
2004-03-31 15:10 ` Andi Kleen
2004-03-31 17:30 ` Ben Greear [this message]
2004-03-31 17:50 ` Andi Kleen
2004-03-31 18:53 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=406B001A.1030901@candelatech.com \
--to=greearb@candelatech.com \
--cc=ak@muc.de \
--cc=netdev@oss.sgi.com \
--cc=vnuorval@tcs.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).