From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Amol Grover <frextrite@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Joel Fernandes <joel@joelfernandes.org>,
Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] cfg80211: Pass lockdep expression to RCU lists
Date: Wed, 19 Feb 2020 22:27:44 +0100 [thread overview]
Message-ID: <407d6295-6990-4ef6-7d36-e08a942607c8@broadcom.com> (raw)
In-Reply-To: <ff8a005c68e512cb3f338b7381853e6b3a3ab293.camel@sipsolutions.net>
On 2/19/2020 10:13 AM, Johannes Berg wrote:
> On Wed, 2020-02-19 at 14:41 +0530, Amol Grover wrote:
>>
>> - WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held());
>> -
>> - list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list) {
>> + list_for_each_entry_rcu(pos, &rdev->sched_scan_req_list, list,
>> + lockdep_rtnl_is_held()) {
>
> Huh, I didn't even know you _could_ do that :)
Me neither ;-). Above you are removing the WARN_ON_ONCE() entirely.
Would it not be good to keep the WARN_ON_ONCE() with only the
!rcu_read_lock_held() check.
Regards,
Arend
next prev parent reply other threads:[~2020-02-19 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 9:11 [PATCH] cfg80211: Pass lockdep expression to RCU lists Amol Grover
2020-02-19 9:13 ` Johannes Berg
2020-02-19 12:47 ` Paul E. McKenney
2020-02-19 21:27 ` Arend Van Spriel [this message]
2020-02-19 21:29 ` Johannes Berg
2020-02-19 21:33 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407d6295-6990-4ef6-7d36-e08a942607c8@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).