From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F66C43381 for ; Sun, 17 Feb 2019 02:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F1A521917 for ; Sun, 17 Feb 2019 02:44:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k9FDmXF8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbfBQCof (ORCPT ); Sat, 16 Feb 2019 21:44:35 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:43287 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbfBQCof (ORCPT ); Sat, 16 Feb 2019 21:44:35 -0500 Received: by mail-pf1-f194.google.com with SMTP id q17so6778094pfh.10 for ; Sat, 16 Feb 2019 18:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1tSgPK96+7ED9yD4phzUL/hPswNQehHnnHuEE0hktcs=; b=k9FDmXF8qrPIFt9wcca0qKa6rYam6PKrAS08ktLUxDqEJwXOoUu3MzatAokWq3h4ET /PlgEc1CuGoAssvOlB52st4a4wmlmsQJDoIB5Fu0fxEOFi6b/8HX5KoK2Qgu+qa1DRo4 XC5xgN1ynZDkOABiUG3i54AAXAfM2HodX2M9g2Jaw4EuSDTGrkHTsFLf33esCsij+ZKY kXSboFeITiceHpkAbDLQGqHa9gwDKXrGNH2/AgV8WryY76+wUVBt6CuY/2wqZLL+Rvg4 p/qoEoo4gZqtOM3gNQJtsGuyzct2aFjABWtrT08dGrfiOykl8CKP8BWQC5NVO6Nq3/fe j7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1tSgPK96+7ED9yD4phzUL/hPswNQehHnnHuEE0hktcs=; b=b9fCKgbrzK2Ew/kPFZdPhYJWmp436R01pWYliMPVauDyR5jK8bQNNCZqu9TD+Y2fHD okLfB2p4oY0xZ4aA0v0lYp7/ofmiGcmukvGlBRzE+WVvJY5TlgZ66G0gpjQBELyZdnad cvQHec3HKtaNOaBeHdo4p8U1OzQhAGzNIuGEgX53hC0Gqvw71v4aijJ4GY3Tgw23XpZc CYS7arCTbnXR3xLtz6tbop32EjF6L1EWsLldl0HQE52RmGLuKFqFgjxk3Te1jAZpZ6+0 sLt3y8Pu1JdL+Bj4FBySopuDhElNaFxBKKGABMwVwDrqmqAREznd9lj1tnbG6/PvT3Yn ISnA== X-Gm-Message-State: AHQUAuZQdq7gVuNSLThRw7monEoOmPk2wpBaw8iHq1L0Rc82YuxEPKpG mvMRBtNHbkrBHGb7UsfgjQllSGvT X-Google-Smtp-Source: AHgI3IaWK25CexWTWnSNa26zLaS3HZNTZdI7uwpZUXl1FiQQBZ0CD5e2bRr6ih/dG3NDxUP+biDMPA== X-Received: by 2002:a63:5922:: with SMTP id n34mr12535105pgb.435.1550371473666; Sat, 16 Feb 2019 18:44:33 -0800 (PST) Received: from [192.168.1.3] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id k128sm12495680pfc.34.2019.02.16.18.44.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 18:44:32 -0800 (PST) Subject: Re: [PATCH net-next 2/4] net: phy: add genphy_c45_an_config_an To: Heiner Kallweit , Andrew Lunn , David Miller , Russell King - ARM Linux Cc: "netdev@vger.kernel.org" References: <0423e795-0215-053f-57ff-386242a6d7ce@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <407e490f-17f6-c9a5-a128-9a27a3230c39@gmail.com> Date: Sat, 16 Feb 2019 18:44:24 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/16/2019 11:51 AM, Heiner Kallweit wrote: > From: Andrew Lunn > C45 configuration of 10/100 and multi-giga bit auto negotiation > advertisement is standardized. Configuration of 1000Base-T however > appears to be vendor specific. Move the generic code out of the > Marvell driver into the common phy-c45.c file. > > Signed-off-by: Andrew Lunn > [hkallweit1@gmail.com: use new helper linkmode_adv_to_mii_10gbt_adv_t and split patch] > Signed-off-by: Heiner Kallweit > --- > drivers/net/phy/phy-c45.c | 44 +++++++++++++++++++++++++++++++++++++++ > include/linux/phy.h | 1 + > 2 files changed, 45 insertions(+) > > diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c > index 0374c50b1..bea1b0c6e 100644 > --- a/drivers/net/phy/phy-c45.c > +++ b/drivers/net/phy/phy-c45.c > @@ -78,6 +78,50 @@ int genphy_c45_pma_setup_forced(struct phy_device *phydev) > } > EXPORT_SYMBOL_GPL(genphy_c45_pma_setup_forced); > > +/** > + * genphy_c45_an_config_an - configure advertisement registers Nit: are not the two "an" redundant" here? Unless the first one means something different in which case naming this: genphy_c45_an_config_aneg() would be clearer? > + * @phydev: target phy_device struct > + * > + * Configure advertisement registers based on modes set in phydev->advertising > + * > + * Returns negative errno code on failure, 0 if advertisement didn't change, > + * or 1 if advertised modes changed. > + */ > +int genphy_c45_an_config_an(struct phy_device *phydev) > +{ > + int changed = 0, ret; > + u32 adv; > + > + linkmode_and(phydev->advertising, phydev->advertising, > + phydev->supported); > + > + adv = linkmode_adv_to_mii_adv_t(phydev->advertising); > + > + ret = phy_modify_mmd(phydev, MDIO_MMD_AN, MDIO_AN_ADVERTISE, > + ADVERTISE_ALL | ADVERTISE_100BASE4 | > + ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM, > + adv); > + if (ret < 0) > + return ret; > + if (ret > 0) > + changed = 1; 'changed' is essentially a short hand for 'ret >= 0' given it is initialized to 0 by default and only assigned 1 if 'ret > 0', and since you do early returns in case 'ret < 0', you might as well drop 'changed' entirely? Other than that and the naming: Reviewed-by: Florian Fainelli -- Florian