From: Eric Dumazet <eric.dumazet@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: af_decnet.c: missing semi-colon and/or indentation?
Date: Thu, 18 Jun 2020 16:35:38 -0700 [thread overview]
Message-ID: <407fa160-aec6-3135-1579-f833bebe59a2@gmail.com> (raw)
In-Reply-To: <4649af05-ac31-4c57-a895-39866504b5fb@infradead.org>
On 6/18/20 4:19 PM, Randy Dunlap wrote:
>
> Please see lines 1250-1251.
>
>
> case TIOCINQ:
> lock_sock(sk);
> skb = skb_peek(&scp->other_receive_queue);
> if (skb) {
> amount = skb->len;
> } else {
> skb_queue_walk(&sk->sk_receive_queue, skb) <<<<<
> amount += skb->len; <<<<<
> }
> release_sock(sk);
> err = put_user(amount, (int __user *)arg);
> break;
>
>
>
> or is this some kind of GCC nested function magic?
>
I do not see a problem
for (bla; bla; bla)
amount += skb->len;
Seems good to me.
>
> commit bec571ec762a4cf855ad4446f833086fc154b60e
> Author: David S. Miller <davem@davemloft.net>
> Date: Thu May 28 16:43:52 2009 -0700
>
> decnet: Use SKB queue and list helpers instead of doing it by-hand.
>
>
>
> thanks.
>
Also decnet should not be any of our concerns in 2020 ?
next prev parent reply other threads:[~2020-06-18 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 23:19 af_decnet.c: missing semi-colon and/or indentation? Randy Dunlap
2020-06-18 23:35 ` Eric Dumazet [this message]
2020-06-19 0:23 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407fa160-aec6-3135-1579-f833bebe59a2@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox