* [PATCH] remove redundant check in de2104x ->get_regs()
@ 2004-04-16 22:37 Chris Wright
2004-04-19 16:38 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Chris Wright @ 2004-04-16 22:37 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Hi Jeff,
Trivial patchlet...ethtool core already caps regs.len at a max of
->get_regs_len():
reglen = ops->get_regs_len(dev);
if (regs.len > reglen)
regs.len = reglen;
So doing the same in the in de2104x driver ->get_regs() is redundant.
Patch below simply removes it to clarify the guarantee of the API.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
===== drivers/net/tulip/de2104x.c 1.29 vs edited =====
--- 1.29/drivers/net/tulip/de2104x.c Wed Mar 17 11:32:53 2004
+++ edited/drivers/net/tulip/de2104x.c Fri Apr 16 15:31:55 2004
@@ -1676,8 +1676,6 @@
{
struct de_private *de = dev->priv;
- if (regs->len > DE_REGS_SIZE)
- regs->len = DE_REGS_SIZE;
regs->version = (DE_REGS_VER << 2) | de->de21040;
spin_lock_irq(&de->lock);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] remove redundant check in de2104x ->get_regs()
2004-04-16 22:37 [PATCH] remove redundant check in de2104x ->get_regs() Chris Wright
@ 2004-04-19 16:38 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-04-19 16:38 UTC (permalink / raw)
To: Chris Wright; +Cc: netdev
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-04-19 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-16 22:37 [PATCH] remove redundant check in de2104x ->get_regs() Chris Wright
2004-04-19 16:38 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).