* [PATCH] fix arm/etherh.c allocation
@ 2004-04-20 18:49 Daniel Ritz
2004-04-22 3:28 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Ritz @ 2004-04-20 18:49 UTC (permalink / raw)
To: Jeff Garzik, Russell King; +Cc: netdev
russell, there's a part of my original patch you missed: allocation of the
netdevice. doesn't need a comment.
against 2.6-bknow
rgds
-daniel
--- 1.23/drivers/net/arm/etherh.c Wed Apr 14 12:23:55 2004
+++ edited/etherh.c Tue Apr 20 20:39:04 2004
@@ -574,7 +574,7 @@
if (ret)
goto out;
- dev = alloc_ei_netdev();
+ dev = __alloc_ei_netdev(sizeof(struct etherh_priv));
if (!dev) {
ret = -ENOMEM;
goto release;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix arm/etherh.c allocation
2004-04-20 18:49 [PATCH] fix arm/etherh.c allocation Daniel Ritz
@ 2004-04-22 3:28 ` Jeff Garzik
2004-04-22 7:33 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2004-04-22 3:28 UTC (permalink / raw)
To: daniel.ritz; +Cc: Russell King, netdev
Daniel Ritz wrote:
> russell, there's a part of my original patch you missed: allocation of the
> netdevice. doesn't need a comment.
>
> against 2.6-bknow
>
> rgds
> -daniel
>
>
> --- 1.23/drivers/net/arm/etherh.c Wed Apr 14 12:23:55 2004
> +++ edited/etherh.c Tue Apr 20 20:39:04 2004
can one of you resend something that applies with 'patch -sp1'?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix arm/etherh.c allocation
2004-04-22 3:28 ` Jeff Garzik
@ 2004-04-22 7:33 ` Russell King
0 siblings, 0 replies; 3+ messages in thread
From: Russell King @ 2004-04-22 7:33 UTC (permalink / raw)
To: Jeff Garzik; +Cc: daniel.ritz, netdev
On Wed, Apr 21, 2004 at 11:28:42PM -0400, Jeff Garzik wrote:
> Daniel Ritz wrote:
> > --- 1.23/drivers/net/arm/etherh.c Wed Apr 14 12:23:55 2004
> > +++ edited/etherh.c Tue Apr 20 20:39:04 2004
>
>
> can one of you resend something that applies with 'patch -sp1'?
I've noticed this as well - I just end up fixing the patch headers
manually. It's a BK bug unfortunately - if you provide a directory
for bk diffs, it messes up like above, but if you give explicit files
it doesn't.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-22 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-20 18:49 [PATCH] fix arm/etherh.c allocation Daniel Ritz
2004-04-22 3:28 ` Jeff Garzik
2004-04-22 7:33 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).