* [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface
@ 2004-04-26 1:30 Krzysztof Halasa
2004-04-26 1:40 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Halasa @ 2004-04-26 1:30 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
Hi,
The attached patch fixes an "oops" in tulip driver when a live interface
is deactivated (i.e. PC Card ejected or module unloaded) without being
brought down first.
Please apply to Linux 2.6. Thanks.
--
Krzysztof Halasa, B*FH
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tulip-rmmod.patch --]
[-- Type: text/x-patch, Size: 497 bytes --]
--- linux/drivers/net/tulip/tulip_core.c 19 Apr 2004 17:04:06 -0000
+++ linux.orig/drivers/net/tulip/tulip_core.c 26 Apr 2004 01:08:31 -0000
@@ -1761,11 +1761,11 @@
return;
tp = netdev_priv(dev);
+ unregister_netdev(dev);
pci_free_consistent (pdev,
sizeof (struct tulip_rx_desc) * RX_RING_SIZE +
sizeof (struct tulip_tx_desc) * TX_RING_SIZE,
tp->rx_ring, tp->rx_ring_dma);
- unregister_netdev (dev);
if (tp->mtable)
kfree (tp->mtable);
#ifndef USE_IO_OPS
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface
2004-04-26 1:30 [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface Krzysztof Halasa
@ 2004-04-26 1:40 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-04-26 1:40 UTC (permalink / raw)
To: Krzysztof Halasa; +Cc: netdev
Krzysztof Halasa wrote:
> Hi,
>
> The attached patch fixes an "oops" in tulip driver when a live interface
> is deactivated (i.e. PC Card ejected or module unloaded) without being
> brought down first.
>
> Please apply to Linux 2.6. Thanks.
hmmm, yeah, looks like a bug. Thanks,
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-04-26 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-26 1:30 [PATCH] 2.6.x Tulip oops while doing eject/rmmod on live interface Krzysztof Halasa
2004-04-26 1:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).