From: Dan Williams <dcbw@redhat.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"David Miller" <davem@davemloft.net>,
"Network Development" <netdev@vger.kernel.org>,
"Carl Yin(殷张成)" <carl.yin@quectel.com>,
"Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH net-next 3/3] net: mhi: Add mbim proto
Date: Mon, 01 Feb 2021 12:53:12 -0600 [thread overview]
Message-ID: <408a5a3589c2acbe59824a8dbee8cbcd2afefbf4.camel@redhat.com> (raw)
In-Reply-To: <CAMZdPi_-b9GWrOcj8GBX8jnxyZN9WZ6nr9KPzXPZZKWfyPW3sQ@mail.gmail.com>
On Mon, 2021-02-01 at 19:27 +0100, Loic Poulain wrote:
> On Mon, 1 Feb 2021 at 19:17, Dan Williams <dcbw@redhat.com> wrote:
> > On Fri, 2021-01-29 at 18:21 -0800, Jakub Kicinski wrote:
> > > On Wed, 27 Jan 2021 18:01:17 +0100 Loic Poulain wrote:
> > > > MBIM has initially been specified by USB-IF for transporting
> > > > data
> > > > (IP)
> > > > between a modem and a host over USB. However some modern modems
> > > > also
> > > > support MBIM over PCIe (via MHI). In the same way as
> > > > QMAP(rmnet),
> > > > it
> > > > allows to aggregate IP packets and to perform context
> > > > multiplexing.
> > > >
> > > > This change adds minimal MBIM support to MHI, allowing to
> > > > support
> > > > MBIM
> > > > only modems. MBIM being based on USB NCM, it reuses some
> > > > helpers
> > > > from
> > > > the USB stack, but the cdc-mbim driver is too USB coupled to be
> > > > reused.
> > > >
> > > > At some point it would be interesting to move on a factorized
> > > > solution,
> > > > having a generic MBIM network lib or dedicated MBIM netlink
> > > > virtual
> > > > interface support.
> >
> > What would a kernel-side MBIM netlink interface do? Just data-
> > plane
> > stuff (like channel setup to create new netdevs), or are you
> > thinking
> > about control-plane stuff like APN definition, radio scans, etc?
>
> Just the data-plane (mbim encoding/decoding/muxing).
Ah yes :) If so, then fully agree.
But is that really specific to MBIM? eg, same kinds of things happen
for QMI. Johannes referred to a more generic WWAN framework that we had
discussed 1.5+ years ago to address these issues. Might be worth
restarting that, perhaps simplifying, and figuring out the minimal set
of generic bits needed to describe/add/delete a data channel for WWAN
control protocols.
Dan
next prev parent reply other threads:[~2021-02-01 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 17:01 [PATCH net-next 1/3] net: mhi: Add RX/TX fixup callbacks Loic Poulain
2021-01-27 17:01 ` [PATCH net-next 2/3] net: mhi: Add dedicated folder Loic Poulain
2021-01-27 17:01 ` [PATCH net-next 3/3] net: mhi: Add mbim proto Loic Poulain
2021-01-30 2:21 ` Jakub Kicinski
2021-02-01 18:17 ` Dan Williams
2021-02-01 18:27 ` Loic Poulain
2021-02-01 18:53 ` Dan Williams [this message]
2021-02-01 20:08 ` Loic Poulain
2021-01-30 14:42 ` Bjørn Mork
2021-02-01 9:23 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408a5a3589c2acbe59824a8dbee8cbcd2afefbf4.camel@redhat.com \
--to=dcbw@redhat.com \
--cc=bjorn@mork.no \
--cc=carl.yin@quectel.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).