From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
kafai@fb.com, hannes@stressinduktion.org,
yoshfuji@linux-ipv6.org, edumazet@google.com,
yanhaishuang@cmss.chinamobile.com
Subject: Re: [patch net-next 10/21] ipv6: fib: Add offload indication to routes
Date: Thu, 3 Aug 2017 10:39:47 -0600 [thread overview]
Message-ID: <4092e040-4fcb-b13b-6de9-f77441c2bfb8@gmail.com> (raw)
In-Reply-To: <20170803112831.1831-11-jiri@resnulli.us>
On 8/3/17 5:28 AM, Jiri Pirko wrote:
> diff --git a/include/uapi/linux/ipv6_route.h b/include/uapi/linux/ipv6_route.h
> index d496c02..33e2a57 100644
> --- a/include/uapi/linux/ipv6_route.h
> +++ b/include/uapi/linux/ipv6_route.h
> @@ -35,6 +35,7 @@
> #define RTF_PREF(pref) ((pref) << 27)
> #define RTF_PREF_MASK 0x18000000
>
> +#define RTF_OFFLOAD 0x20000000 /* offloaded route */
> #define RTF_PCPU 0x40000000 /* read-only: can not be set by user */
> #define RTF_LOCAL 0x80000000
PCPU as a UAPI flag was a mistake; it is a flag internal to IPv6 stack
and really makes no sense to the user. The OFFLOAD should not follow
suit especially given the limited uapi bits left.
next prev parent reply other threads:[~2017-08-03 16:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 11:28 [patch net-next 00/21] mlxsw: Support for IPv6 UC router Jiri Pirko
2017-08-03 11:28 ` [patch net-next 01/21] net: core: Make the FIB notification chain generic Jiri Pirko
2017-08-03 11:28 ` [patch net-next 02/21] mlxsw: spectrum_router: Ignore address families other than IPv4 Jiri Pirko
2017-08-03 11:28 ` [patch net-next 03/21] rocker: " Jiri Pirko
2017-08-03 11:28 ` [patch net-next 04/21] net: fib_rules: Implement notification logic in core Jiri Pirko
2017-08-03 11:28 ` [patch net-next 05/21] ipv6: fib_rules: Check if rule is a default rule Jiri Pirko
2017-08-03 11:28 ` [patch net-next 06/21] ipv6: fib: Add FIB notifiers callbacks Jiri Pirko
2017-08-03 11:28 ` [patch net-next 07/21] ipv6: fib: Add in-kernel notifications for route add / delete Jiri Pirko
2017-08-03 11:28 ` [patch net-next 08/21] ipv6: fib_rules: Dump rules during registration to FIB chain Jiri Pirko
2017-08-03 11:28 ` [patch net-next 09/21] ipv6: fib: Dump tables " Jiri Pirko
2017-08-03 11:28 ` [patch net-next 10/21] ipv6: fib: Add offload indication to routes Jiri Pirko
2017-08-03 16:39 ` David Ahern [this message]
2017-08-03 11:28 ` [patch net-next 11/21] ipv6: fib: Don't assume only nodes hold a reference on routes Jiri Pirko
2017-08-03 11:28 ` [patch net-next 12/21] ipv6: fib: Unlink replaced routes from their nodes Jiri Pirko
2017-08-03 11:28 ` [patch net-next 13/21] ipv6: Regenerate host route according to node pointer upon loopback up Jiri Pirko
2017-08-03 11:28 ` [patch net-next 14/21] ipv6: Regenerate host route according to node pointer upon interface up Jiri Pirko
2017-08-03 11:28 ` [patch net-next 15/21] ipv6: fib: Add helpers to hold / drop a reference on rt6_info Jiri Pirko
2017-08-03 11:28 ` [patch net-next 16/21] mlxsw: spectrum_router: Demultiplex FIB event based on family Jiri Pirko
2017-08-03 11:28 ` [patch net-next 17/21] mlxsw: spectrum_router: Sanitize IPv6 FIB rules Jiri Pirko
2017-08-03 11:28 ` [patch net-next 18/21] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion Jiri Pirko
2017-08-03 11:28 ` [patch net-next 19/21] mlxsw: spectrum_router: Add support for route replace Jiri Pirko
2017-08-03 11:28 ` [patch net-next 20/21] mlxsw: spectrum_router: Abort on source-specific routes Jiri Pirko
2017-08-03 11:28 ` [patch net-next 21/21] mlxsw: spectrum_router: Don't ignore IPv6 notifications Jiri Pirko
2017-08-03 22:36 ` [patch net-next 00/21] mlxsw: Support for IPv6 UC router David Miller
2017-08-03 22:39 ` David Ahern
2017-08-03 22:41 ` David Miller
2017-08-03 22:54 ` David Ahern
2017-08-04 8:50 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4092e040-4fcb-b13b-6de9-f77441c2bfb8@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kafai@fb.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=yanhaishuang@cmss.chinamobile.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).