netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT
@ 2004-05-07 10:43 Christoph Hellwig
  2004-05-11  7:07 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-05-07 10:43 UTC (permalink / raw)
  To: jgarzik; +Cc: netdev

*grr* - this one slipped in after my last round of audits it seems.


--- 1.15/drivers/net/gt96100eth.c	Mon Apr  5 22:31:23 2004
+++ edited/drivers/net/gt96100eth.c	Mon May  3 13:22:22 2004
@@ -1070,22 +1070,18 @@
 {
 	int retval;
     
-	MOD_INC_USE_COUNT;
-
 	dbg(2, "%s: dev=%p\n", __FUNCTION__, dev);
 
 	// Initialize and startup the GT-96100 ethernet port
 	if ((retval = gt96100_init(dev))) {
 		err("error in gt96100_init\n");
 		free_irq(dev->irq, dev);
-		MOD_DEC_USE_COUNT;
 		return retval;
 	}
 
 	if ((retval = request_irq(dev->irq, &gt96100_interrupt,
 				  SA_SHIRQ, dev->name, dev))) {
 		err("unable to get IRQ %d\n", dev->irq);
-		MOD_DEC_USE_COUNT;
 		return retval;
 	}
 	
@@ -1106,8 +1102,6 @@
 	}
 
 	free_irq(dev->irq, dev);
-    
-	MOD_DEC_USE_COUNT;
 	return 0;
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT
  2004-05-07 10:43 [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT Christoph Hellwig
@ 2004-05-11  7:07 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-05-11  7:07 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: netdev

Christoph Hellwig wrote:
> *grr* - this one slipped in after my last round of audits it seems.
> 
> 
> --- 1.15/drivers/net/gt96100eth.c	Mon Apr  5 22:31:23 2004
> +++ edited/drivers/net/gt96100eth.c	Mon May  3 13:22:22 2004


applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-11  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-07 10:43 [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT Christoph Hellwig
2004-05-11  7:07 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).