From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: MSEC_TO_JIFFIES is messed up... Date: Wed, 12 May 2004 14:42:02 -0400 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <40A26FFA.4030701@pobox.com> References: <20040512020700.6f6aa61f.akpm@osdl.org> <20040512181903.GG13421@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , mingo@elte.hu, linux-kernel@vger.kernel.org, Netdev Return-path: To: Greg KH In-Reply-To: <20040512181903.GG13421@kroah.com> List-Id: netdev.vger.kernel.org Greg KH wrote: > On Wed, May 12, 2004 at 02:07:00AM -0700, Andrew Morton wrote: > >>drivers/usb/host/ehci.h:599: warning: `MSEC_TO_JIFFIES' redefined >>include/asm/param.h:9: warning: this is the location of the previous definition >>In file included from drivers/usb/host/ohci-hcd.c:127: >>drivers/usb/host/ohci.h:400: warning: `MSEC_TO_JIFFIES' redefined >>include/asm/param.h:9: warning: this is the location of the previous definition > > > Woah, that's new. And wrong. The code in include/asm-i386/param.h that > says: > # define JIFFIES_TO_MSEC(x) (x) > # define MSEC_TO_JIFFIES(x) (x) > > Is not correct. Look at kernel/sched.c for verification of this :) Yes, that is _massively_ broken. Tangent: One of the SCTP folks was cleaning up all the random jif-to-msec and msec-to-jif macros into include/linux/time.h. Need to dig that up and merge it. Jeff