netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nivedita Singhvi <niv@us.ibm.com>
To: Marc Herbert <marc.herbert@free.fr>
Cc: netdev@oss.sgi.com
Subject: Re: TcpOutSegs way too optimistic (netstat -s)
Date: Fri, 14 May 2004 15:51:31 -0700	[thread overview]
Message-ID: <40A54D73.2050108@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0405150027230.8281@fcat>

Marc Herbert wrote:

>Oups, forget the first patch, it did not tcp_enter_cwr() when
>NET_XMIT_CN.
>
>See hopefully correct patch below. Sorry for the noise.
>
>  
>

I'm not sure I agree with this patch.  Ideally, every layer should count
what it sent out, and what it drops. If a lower layer drops the segment/
packet for any reason, that is the responsibility of the lower layer to
count.  This includes the qdisc layer (a topic I will come back to).
 
If a queing discipline were counting all incoming packets, regardless
of whether they later dropped them or not, then there would be an
inconsistency between how many TCP sent out and how many
the  layer below received.

Currently, the default queing discipline statistics (dropped) are not
displayed anywhere. I have a patch that displays them in /proc/net/
along with the dev stats, which at best is a hack.

They are available if you have tc and qd support compiled, but not
via a generic statistics gathering utility  like netstat -s, a fact which
a lot of people complain about.  From previous suggestions and
conversations it was proposed that netstat -s be at least enhanced
to show qdisc drops (using netlink sockets, not /proc, although it
would be manyfold convenience to have them in /proc in some
suitable place).

I'd appreciate any thoughts/feedback on the issue :). What's the
best way to go about doing this?

thanks,
Nivedita

  reply	other threads:[~2004-05-14 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-14 22:11 TcpOutSegs way too optimistic (netstat -s) Marc Herbert
2004-05-14 22:31 ` Marc Herbert
2004-05-14 22:51   ` Nivedita Singhvi [this message]
2004-05-15  0:51     ` Marc Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A54D73.2050108@us.ibm.com \
    --to=niv@us.ibm.com \
    --cc=marc.herbert@free.fr \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).