netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]: Fix skb leak in igmpv3_newpack
@ 2004-05-28 10:54 Patrick McHardy
  2004-05-29 19:39 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2004-05-28 10:54 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev

[-- Attachment #1: Type: text/plain, Size: 133 bytes --]

This patch fixes an skb-leak in igmpv3_newpack. skb isn't
freed when rt->rt_src == 0. Patch applies to 2.4 and 2.6.

Regards
Patrick

[-- Attachment #2: igmpv3_newpack-skbleak.diff --]
[-- Type: text/x-patch, Size: 530 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/05/28 12:30:41+02:00 kaber@trash.net 
#   [IPV4]: Fix skb leak in igmpv3_newpack
# 
# net/ipv4/igmp.c
#   2004/05/28 12:30:34+02:00 kaber@trash.net +1 -0
#   [IPV4]: Fix skb leak in igmpv3_newpack
# 
diff -Nru a/net/ipv4/igmp.c b/net/ipv4/igmp.c
--- a/net/ipv4/igmp.c	2004-05-28 12:35:28 +02:00
+++ b/net/ipv4/igmp.c	2004-05-28 12:35:28 +02:00
@@ -292,6 +292,7 @@
 		}
 	}
 	if (rt->rt_src == 0) {
+		kfree_skb(skb);
 		ip_rt_put(rt);
 		return 0;
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-29 19:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-28 10:54 [PATCH]: Fix skb leak in igmpv3_newpack Patrick McHardy
2004-05-29 19:39 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).