* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update [not found] ` <20040530094120.61b22d2e.rddunlap@osdl.org> @ 2004-05-30 17:51 ` Jeff Garzik 2004-05-30 19:37 ` Adrian Bunk 0 siblings, 1 reply; 6+ messages in thread From: Jeff Garzik @ 2004-05-30 17:51 UTC (permalink / raw) To: bunk, linux-kernel Cc: Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton [-- Attachment #1: Type: text/plain, Size: 133 bytes --] NET_GIGE is rightly dependent on NET_ETHERNET, as it is a subset. I wonder if the attached patch "fixes" peoples config problems :) [-- Attachment #2: patch --] [-- Type: text/plain, Size: 457 bytes --] ===== drivers/net/Kconfig 1.74 vs edited ===== --- 1.74/drivers/net/Kconfig 2004-05-27 16:42:40 -04:00 +++ edited/drivers/net/Kconfig 2004-05-30 13:49:48 -04:00 @@ -163,7 +163,7 @@ depends on NETDEVICES config NET_ETHERNET - bool "Ethernet (10 or 100Mbit)" + bool "Ethernet (10/100/1000/10000 Mbit)" ---help--- Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common type of Local Area Network (LAN) in universities and companies. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update 2004-05-30 17:51 ` [patch] Re: Gigabit Kconfig problems with yesterday's update Jeff Garzik @ 2004-05-30 19:37 ` Adrian Bunk 2004-05-30 20:06 ` Linus Torvalds 0 siblings, 1 reply; 6+ messages in thread From: Adrian Bunk @ 2004-05-30 19:37 UTC (permalink / raw) To: Jeff Garzik Cc: linux-kernel, Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton On Sun, May 30, 2004 at 01:51:33PM -0400, Jeff Garzik wrote: > NET_GIGE is rightly dependent on NET_ETHERNET, as it is a subset. > > I wonder if the attached patch "fixes" peoples config problems :) > > ===== drivers/net/Kconfig 1.74 vs edited ===== > --- 1.74/drivers/net/Kconfig 2004-05-27 16:42:40 -04:00 > +++ edited/drivers/net/Kconfig 2004-05-30 13:49:48 -04:00 > @@ -163,7 +163,7 @@ > depends on NETDEVICES > > config NET_ETHERNET > - bool "Ethernet (10 or 100Mbit)" > + bool "Ethernet (10/100/1000/10000 Mbit)" > ---help--- > Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common > type of Local Area Network (LAN) in universities and companies. This is not sufficient since it's still under the "Ethernet (10 or 100Mbit)" menu. What about the patch below? cu Adrian --- linux-2.6.7-rc2-full/drivers/net/Kconfig.old 2004-05-30 21:29:46.000000000 +0200 +++ linux-2.6.7-rc2-full/drivers/net/Kconfig 2004-05-30 21:34:42.000000000 +0200 @@ -159,11 +159,8 @@ # Ethernet # -menu "Ethernet (10 or 100Mbit)" - depends on NETDEVICES - config NET_ETHERNET - bool "Ethernet (10 or 100Mbit)" + bool "Ethernet (10/100/1000/10000 Mbit)" ---help--- Ethernet (also called IEEE 802.3 or ISO 8802-2) is the most common type of Local Area Network (LAN) in universities and companies. @@ -188,6 +185,9 @@ kernel: saying N will just cause the configurator to skip all the questions about Ethernet network cards. If unsure, say N. +menu "Ethernet (10/100 Mbit)" + depends on NET_ETHERNET + config MII tristate "Generic Media Independent Interface device support" depends on NET_ETHERNET @@ -1875,7 +1875,7 @@ # menu "Gigabit Ethernet (1000/10000 Mbit)" - depends on NETDEVICES + depends on NET_ETHERNET config NET_GIGE bool "Gigabit Ethernet (1000/10000 Mbit) controller support" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update 2004-05-30 19:37 ` Adrian Bunk @ 2004-05-30 20:06 ` Linus Torvalds 2004-05-30 20:43 ` Jeff Garzik 2004-05-31 7:32 ` Christoph Hellwig 0 siblings, 2 replies; 6+ messages in thread From: Linus Torvalds @ 2004-05-30 20:06 UTC (permalink / raw) To: Adrian Bunk Cc: Jeff Garzik, linux-kernel, Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton On Sun, 30 May 2004, Adrian Bunk wrote: > > > This is not sufficient since it's still under the > "Ethernet (10 or 100Mbit)" menu. > > What about the patch below? > > config NET_ETHERNET > - bool "Ethernet (10 or 100Mbit)" > + bool "Ethernet (10/100/1000/10000 Mbit)" Ok, this part is obviously sane. However: > +menu "Ethernet (10/100 Mbit)" > + depends on NET_ETHERNET > + > > menu "Gigabit Ethernet (1000/10000 Mbit)" > - depends on NETDEVICES > + depends on NET_ETHERNET is it really sane these days to split out gigabit from the "regular" ethernets? gigabit ethernet is getting quite a bit more common than it used to be, and a lot of the gigabit devices are just "standard ethernet" as far as the user is concerned, and in fact they are often _used_ in just regular 10/100Mbps setups. In other words: it's quite understandable if somebody doesn't even _realize_ that his chip supports gigabit speeds these days. So wouldn't the right fix be to just remove the distinction between "regular" and "gigabit" ethernet, and put them all in the same menu? If the menu then grows really big, maybe we can split it according to some _saner_ split. Not that I can see off-hand what that would be, but.. Linus ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update 2004-05-30 20:06 ` Linus Torvalds @ 2004-05-30 20:43 ` Jeff Garzik 2004-05-31 7:32 ` Christoph Hellwig 1 sibling, 0 replies; 6+ messages in thread From: Jeff Garzik @ 2004-05-30 20:43 UTC (permalink / raw) To: Linus Torvalds Cc: Adrian Bunk, linux-kernel, Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton Linus Torvalds wrote: > is it really sane these days to split out gigabit from the "regular" > ethernets? gigabit ethernet is getting quite a bit more common than it > used to be, and a lot of the gigabit devices are just "standard ethernet" > as far as the user is concerned, and in fact they are often _used_ in just > regular 10/100Mbps setups. > In other words: it's quite understandable if somebody doesn't even > _realize_ that his chip supports gigabit speeds these days. That's ok. Most users have no idea that their "Surecom 1234 Zippy Ethernet" is really an 8139 chip, and that they need the 8139too driver. Kernel configuration is for kernel developers, kernel vendors (distributions), and power users, all of whom are expected to know what they are doing. So, I disagree with that argument. However... > If the menu then grows really big, maybe we can split it according to some > _saner_ split. Not that I can see off-hand what that would be, but.. ...I won't reject arguments based on general annoyance, or specific annoyance at the categorizing. This change was the way I preferred that the network driver Kconfig start moving, with future categorizations as well -- the overall goal being that eventually you'll select among several classes of devices, instead of today's innumerably long list of devices from the first days of ethernet to today's 10Gbps. The easy fix is just to cset -x the change I commited. Ethernet and "gigabit ethernet" will be in separate menus, but there will not a separate CONFIG_NET_GIGE option. I won't complain, if people feel 'cset -x' is warranted. It's just a config option, not anything terribly important[1] Jeff [1] Of course, this is lkml, the big arguments are always over trivialities like this ;-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update 2004-05-30 20:06 ` Linus Torvalds 2004-05-30 20:43 ` Jeff Garzik @ 2004-05-31 7:32 ` Christoph Hellwig 2004-05-31 10:00 ` Paul Mackerras 1 sibling, 1 reply; 6+ messages in thread From: Christoph Hellwig @ 2004-05-31 7:32 UTC (permalink / raw) To: Linus Torvalds Cc: Adrian Bunk, Jeff Garzik, linux-kernel, Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton On Sun, May 30, 2004 at 01:06:53PM -0700, Linus Torvalds wrote: > is it really sane these days to split out gigabit from the "regular" > ethernets? gigabit ethernet is getting quite a bit more common than it > used to be, and a lot of the gigabit devices are just "standard ethernet" > as far as the user is concerned, and in fact they are often _used_ in just > regular 10/100Mbps setups. Or have a gige chip that's crippled to do only 10/100, like the sungem on my ibook. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Re: Gigabit Kconfig problems with yesterday's update 2004-05-31 7:32 ` Christoph Hellwig @ 2004-05-31 10:00 ` Paul Mackerras 0 siblings, 0 replies; 6+ messages in thread From: Paul Mackerras @ 2004-05-31 10:00 UTC (permalink / raw) To: Christoph Hellwig Cc: Linus Torvalds, Adrian Bunk, Jeff Garzik, linux-kernel, Randy.Dunlap, Danny ter Haar, wa1ter, dth, Netdev, Andrew Morton Christoph Hellwig writes: > Or have a gige chip that's crippled to do only 10/100, like the sungem > on my ibook. I think it is not that the sungem itself is crippled, rather that the phy can only do 10/100. I agree that the division between 10/100 and gigabit ethernet is pretty useless. I note that sungem didn't get put in the gigabit list, for instance. Paul. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-05-31 10:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <40B8A37D.1090802@myrealbox.com>
[not found] ` <20040530134544.GE13111@fs.tum.de>
[not found] ` <20040530143734.GA24627@dth.net>
[not found] ` <20040530094120.61b22d2e.rddunlap@osdl.org>
2004-05-30 17:51 ` [patch] Re: Gigabit Kconfig problems with yesterday's update Jeff Garzik
2004-05-30 19:37 ` Adrian Bunk
2004-05-30 20:06 ` Linus Torvalds
2004-05-30 20:43 ` Jeff Garzik
2004-05-31 7:32 ` Christoph Hellwig
2004-05-31 10:00 ` Paul Mackerras
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).