* [PATCH 2.6 1/3] e100: stepping over err return code
@ 2004-06-10 18:16 Scott Feldman
2004-06-10 23:33 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Scott Feldman @ 2004-06-10 18:16 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, scott.feldman
* Spotted by Jay Vosburgh [fubar@us.ibm.com]. err return code was getting
stepped on in the case where we need to report low or no cb resources,
which in turn messed up the netif_stop_queue logic in xmit_frame.
Signed-off by: scott.feldman@intel.com
--------
--- linux-2.5/drivers/net/e100.c 2004-06-10 11:06:03.457155768 -0700
+++ linux-2.5/drivers/net/e100.c.mod 2004-06-10 11:06:59.105695904 -0700
@@ -827,8 +827,8 @@ static inline int e100_exec_cb(struct ni
cb->prev->command &= cpu_to_le16(~cb_s);
while(nic->cb_to_send != nic->cb_to_use) {
- if(unlikely((err = e100_exec_cmd(nic, nic->cuc_cmd,
- nic->cb_to_send->dma_addr)))) {
+ if(unlikely(e100_exec_cmd(nic, nic->cuc_cmd,
+ nic->cb_to_send->dma_addr))) {
/* Ok, here's where things get sticky. It's
* possible that we can't schedule the command
* because the controller is too busy, so
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-10 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-10 18:16 [PATCH 2.6 1/3] e100: stepping over err return code Scott Feldman
2004-06-10 23:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).