From: Jeff Garzik <jgarzik@pobox.com>
To: jt@hpl.hp.com
Cc: netdev@oss.sgi.com, Nimrod Zimerman <zimerman@mailandnews.com>,
Niibe Yutaka <gniibe@mri.co.jp>
Subject: Re: [PATCH] Plip ioctl bug
Date: Fri, 11 Jun 2004 19:27:50 -0400 [thread overview]
Message-ID: <40CA3FF6.1020408@pobox.com> (raw)
In-Reply-To: <20040611231154.GA21485@bougret.hpl.hp.com>
Jean Tourrilhes wrote:
> Hi all,
>
> Plip should verify that it got the proper ioctl to avoid false
> positive. User reported that plip suddenly was gaining wireless
> capability ;-)
> Have fun...
>
> Jean
>
> Signed-off-by: $me
> ------------------------------------------
>
> diff -u -p linux/drivers/net/plip.b0.c linux/drivers/net/plip.c
> --- linux/drivers/net/plip.b0.c Fri Jun 11 16:00:13 2004
> +++ linux/drivers/net/plip.c Fri Jun 11 16:03:14 2004
> @@ -1219,6 +1219,11 @@ plip_ioctl(struct net_device *dev, struc
> struct net_local *nl = netdev_priv(dev);
> struct plipconf *pc = (struct plipconf *) &rq->ifr_data;
>
> + /* Respond only to our IOCTL, ignore other IOCTLs, such as
> + * Ethtool and Wireless Extensions. Jean II */
> + if(cmd != SIOCDEVPLIP)
> + return -EOPNOTSUPP;
> +
> switch(pc->pcmd) {
> case PLIP_GET_TIMEOUT:
> pc->trigger = nl->trigger;
already in the latest 2.6.x :)
next prev parent reply other threads:[~2004-06-11 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 23:11 [PATCH] Plip ioctl bug Jean Tourrilhes
2004-06-11 23:27 ` Jeff Garzik [this message]
2004-06-11 23:40 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CA3FF6.1020408@pobox.com \
--to=jgarzik@pobox.com \
--cc=gniibe@mri.co.jp \
--cc=jt@hpl.hp.com \
--cc=netdev@oss.sgi.com \
--cc=zimerman@mailandnews.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).