From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@oss.sgi.com, alan@redhat.com, akpm@osdl.org
Subject: Re: [PATCH 2.6.7-rc3-mm2 2/5] via-velocity: uniformize use of OWNED_BY_NIC
Date: Fri, 18 Jun 2004 17:02:02 -0400 [thread overview]
Message-ID: <40D3584A.9010009@pobox.com> (raw)
In-Reply-To: <20040618221142.A20210@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Introduce velocity_give_rx_desc() to uniformize the use of OWNED_BY_NIC
> through the driver.
>
> diff -puN drivers/net/via-velocity.c~via-velocity-30 drivers/net/via-velocity.c
> --- linux-2.6.7-rc3/drivers/net/via-velocity.c~via-velocity-30 2004-06-18 21:34:14.000000000 +0200
> +++ linux-2.6.7-rc3-fr/drivers/net/via-velocity.c 2004-06-18 21:34:14.000000000 +0200
> @@ -465,6 +465,12 @@ static void velocity_init_cam_filter(str
> }
> }
>
> +static inline void velocity_give_rx_desc(struct rx_desc *rd)
> +{
> + *(u32 *)&rd->rdesc0 = 0;
> + rd->rdesc0.owner = cpu_to_le32(OWNED_BY_NIC);
> +}
The patch itself is OK, and I will merge, but I wonder:
isn't a wmb() needed perhaps?
Jeff
next prev parent reply other threads:[~2004-06-18 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 20:10 [PATCH 2.6.7-rc3-mm2 1/5] via-velocity: PCI ID move Francois Romieu
2004-06-18 20:11 ` [PATCH 2.6.7-rc3-mm2 2/5] via-velocity: uniformize use of OWNED_BY_NIC Francois Romieu
2004-06-18 20:13 ` [PATCH 2.6.7-rc3-mm2 3/5] via-velocity: velocity_receive_frame diets Francois Romieu
2004-06-18 20:14 ` [PATCH 2.6.7-rc3-mm2 4/5] via-velocity: Rx buffers allocation rework Francois Romieu
2004-06-18 20:16 ` [PATCH 2.6.7-rc3-mm2 5/5] via-velocity: Rx copybreak Francois Romieu
2004-06-18 20:34 ` Alan Cox
2004-06-18 21:02 ` Jeff Garzik [this message]
2004-06-18 21:42 ` [PATCH 2.6.7-rc3-mm2 2/5] via-velocity: uniformize use of OWNED_BY_NIC Francois Romieu
[not found] ` <40D4AA3C.4090606@pobox.com>
2004-06-20 8:51 ` [PATCH 2.6.7-rc3-mm2 1/5] via-velocity: PCI ID move Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D3584A.9010009@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).