From: Manfred Spraul <manfred@colorfullife.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH] cleanup large frame handling for natsemi.c
Date: Sun, 20 Jun 2004 14:14:59 +0200 [thread overview]
Message-ID: <40D57FC3.9040008@colorfullife.com> (raw)
Hi,
The DP83815/6 by default rejects frames longer that 1518 bytes
(including crc). This means that a special flag must be set for 8021q -
otherwise mtu sized packets are dropped.
The current driver enables this flag only if the buffer size is above
1536 bytes - this is wrong. Additionally, the nic writes up to two bytes
behind the indicated end of the buffer. This is not documented, thus
I've added 64 bytes - just to be safe.
The patch also removes RX_OFFSET from the rx buffer allocation: The nic
can only receive to 32-bit aligned addresses, it's a left over from a
skeleton driver.
Jeff, could you apply it? I've stress tested vlan for an hour with
tbench and parallel kernel compiles, not obvious problems.
--
Manfred
next reply other threads:[~2004-06-20 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-20 12:14 Manfred Spraul [this message]
2004-06-20 16:30 ` [PATCH] cleanup large frame handling for natsemi.c Jeff Garzik
2004-06-20 16:43 ` Manfred Spraul
2004-06-20 18:38 ` Jeff Garzik
2004-06-20 19:31 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D57FC3.9040008@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).