netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] get rid of __OPTIMIZE__ requirement in net drivers
Date: Tue, 22 Jun 2004 15:52:34 -0400	[thread overview]
Message-ID: <40D88E02.1030701@pobox.com> (raw)
In-Reply-To: <20040622113052.1ef2cb7b@dell_ss3.pdx.osdl.net>

Stephen Hemminger wrote:
> Several network drivers have checks that they are only built with -O.
> This breaks checking with sparse and other tools, and seems like a holdover from
> when drivers were built out of tree and the kernel build system was less stable.
> This patch gets rid of these.


Guess is 50% correct... holdover from people compiling the drivers 
out-of-tree using a single shell command (that runs gcc), found at the 
bottom of the driver.

No objection to the patch, though, just saying :)  I'll apply...

	Jeff

  reply	other threads:[~2004-06-22 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-22 18:30 [PATCH] get rid of __OPTIMIZE__ requirement in net drivers Stephen Hemminger
2004-06-22 19:52 ` Jeff Garzik [this message]
2004-07-01  3:27 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40D88E02.1030701@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).