* [PATCH] [sparse] dgrs -- cleanup warnings
@ 2004-06-22 21:27 Stephen Hemminger
2004-07-01 3:26 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2004-06-22 21:27 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
DGRS driver sparse fixes. Add annotation to ioctl structure and get rid of '#if XXX'
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
diff -Nru a/drivers/net/dgrs.h b/drivers/net/dgrs.h
--- a/drivers/net/dgrs.h 2004-06-22 14:25:43 -07:00
+++ b/drivers/net/dgrs.h 2004-06-22 14:25:43 -07:00
@@ -26,7 +26,7 @@
typedef struct dgrs_ioctl {
unsigned short cmd; /* Command to run */
unsigned short len; /* Length of the data buffer */
- unsigned char *data; /* Pointer to the data buffer */
+ unsigned char __user *data;/* Pointer to the data buffer */
unsigned short port; /* port number for command, if needed */
unsigned short filter; /* filter number for command, if needed */
} DGRS_IOCTL;
diff -Nru a/drivers/net/dgrs_asstruct.h b/drivers/net/dgrs_asstruct.h
--- a/drivers/net/dgrs_asstruct.h 2004-06-22 14:25:43 -07:00
+++ b/drivers/net/dgrs_asstruct.h 2004-06-22 14:25:43 -07:00
@@ -4,7 +4,7 @@
* $Id: asstruct.h,v 1.1.1.1 1994/10/23 05:08:32 rick Exp $
*/
-#if ASSEMBLER
+#ifdef ASSEMBLER
# define MO(t,a) (a)
# define VMO(t,a) (a)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [sparse] dgrs -- cleanup warnings
2004-06-22 21:27 [PATCH] [sparse] dgrs -- cleanup warnings Stephen Hemminger
@ 2004-07-01 3:26 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-07-01 3:26 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
bounced: OK but patch(1) rejected. please rediff and resubmit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-01 3:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-22 21:27 [PATCH] [sparse] dgrs -- cleanup warnings Stephen Hemminger
2004-07-01 3:26 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).