From: Jeff Garzik <jgarzik@pobox.com>
To: "Venkatesan, Ganesh" <ganesh.venkatesan@intel.com>
Cc: Jim Keniston <jkenisto@us.ibm.com>,
David Dillow <dave@thedillows.org>,
Anton Blanchard <anton@samba.org>, Netdev <netdev@oss.sgi.com>,
cramerj <cramerj@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>,
jonmason@us.ibm.com
Subject: Re: Network device driver probe issues
Date: Fri, 16 Jul 2004 15:52:58 -0400 [thread overview]
Message-ID: <40F8321A.7000404@pobox.com> (raw)
In-Reply-To: <468F3FDA28AA87429AD807992E22D07E01CEF1BF@orsmsx408>
Venkatesan, Ganesh wrote:
> We've fixed the e100 to have the same logic as e1000. I like the typhoon
> driver idea.
Unfortunately both are wrong.
e1000 should not be using dev_alloc_name(), and patches to add that to
e100 will not be accepted.
e100 should not be referencing netdev->name until after
register_netdev() completes.
The typhoon solution is fine with me. Other drivers don't bother and
simply use pci_name() during probe. It's up to you as maintainer.
Jeff
next prev parent reply other threads:[~2004-07-16 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-16 19:15 Network device driver probe issues Venkatesan, Ganesh
2004-07-16 19:52 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-15 13:52 Anton Blanchard
2004-07-15 23:34 ` Jeff Garzik
2004-07-16 1:04 ` Jim Keniston
2004-07-16 4:49 ` David Dillow
2004-07-16 18:26 ` Jim Keniston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F8321A.7000404@pobox.com \
--to=jgarzik@pobox.com \
--cc=anton@samba.org \
--cc=cramerj@intel.com \
--cc=dave@thedillows.org \
--cc=ganesh.venkatesan@intel.com \
--cc=jkenisto@us.ibm.com \
--cc=john.ronciak@intel.com \
--cc=jonmason@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).