From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF2B626AFB; Sun, 25 May 2025 19:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748202139; cv=none; b=Kx55bvU8SfBBapmwi8PF1yYLFSj62+vXIRFeNdDi98v38EaF9dc9nbi0Ev9wmtoZW7qhxpyPcA7KAVhmn15h406TqmBt6D2HpoxQuSHUXFpclHw0uwKZm2VAGaZLCJUWO95OAs9OYPDWA2K9QK2QSmFTewHN0VyF1UJQHU/dLZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748202139; c=relaxed/simple; bh=9hWHDBpeJtHOsbWUFyhWWQ8ys3+lcEzg/PZcy+7Dr3s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OPQu2/ETwRmNv1P84+imK10OhYR7+OnAdL35pxzgLZHnXfOCaq6uOIk1mxo9rfznbMTQZTfpMlJCQRTeLdP97qdP5WrBV9hmPWu1o2eyEID9O6SyZ6yz0ruoJeF9DSHA+N8/Najfmszdaock5pqdNyu499U6t8q+kzsiGjMELIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=tRv8tElz; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tRv8tElz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=uMNeJr2TyJIxfy/QCHZd2896lqarzp8ruZrKjjxo/WQ=; b=tRv8tElz3u9eGmgkleJV/yI2qU 9ck3euwBfQnLLOn5tQPjfnbFazHiCAkEgksYynl6/B7/PWb8BwQWXOCiwMCUHw985MciCM460B0Vc 2vi21zoNY2ZwIypc/Lh3zAT2sIazMZpVi5swzuMGC48RWTSwcRa00cyMRxa1ShbjmWWw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uJHEU-00Dx4H-SA; Sun, 25 May 2025 21:42:06 +0200 Date: Sun, 25 May 2025 21:42:06 +0200 From: Andrew Lunn To: george.moussalem@outlook.com Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Philipp Zabel , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 3/5] net: phy: qcom: at803x: Add Qualcomm IPQ5018 Internal PHY support Message-ID: <40b427b8-b0d0-474b-a7c6-46641d1940b9@lunn.ch> References: <20250525-ipq5018-ge-phy-v1-0-ddab8854e253@outlook.com> <20250525-ipq5018-ge-phy-v1-3-ddab8854e253@outlook.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250525-ipq5018-ge-phy-v1-3-ddab8854e253@outlook.com> > + phy_write_mmd(phydev, MDIO_MMD_PCS, IPQ5018_PHY_MMD3_AZ_CTRL1, > + IPQ5018_PHY_MMD3_AZ_CTRL1_VAL); Using MMD3 in the name is a good idea, but PCS would be better. Not everybody knows MDIO_MMD_PCS == 3. Andrew --- pw-bot: cr