From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gal Pressman <galp@mellanox.com>
Subject: Re: [PATCH net-next 1/6] net: Fix netdev_WARN_ONCE macro
Date: Sun, 7 Jan 2018 11:31:48 +0200
Message-ID: <40b65abb-9aac-21eb-a474-cd3d63c730e4@mellanox.com>
References: <1515077763-27991-1-git-send-email-galp@mellanox.com>
 <1515077763-27991-2-git-send-email-galp@mellanox.com>
 <20180105.133519.1602365963790420581.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-he1eur01on0086.outbound.protection.outlook.com ([104.47.0.86]:13682
        "EHLO EUR01-HE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751396AbeAGJcE (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 7 Jan 2018 04:32:04 -0500
In-Reply-To: <20180105.133519.1602365963790420581.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 05-Jan-18 20:35, David Miller wrote:
> From: Gal Pressman <galp@mellanox.com>
> Date: Thu,  4 Jan 2018 16:55:58 +0200
> 
>> netdev_WARN_ONCE is broken (whoops..), fix it.
> 
> You don't say how it is broken and how you are fixing that
> brokenness, and you must do this.
> 
> Yes, if I stare at your patch for a few minutes I can see
> the missing "," but you could have saved everyone reviewing
> this patch (now and in the future) by writing a proper and
> complete commit message.
> 

Thank you for reviewing,
I will fix the commit message and submit v2.