From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3CE939BFEE for ; Mon, 4 May 2026 12:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899578; cv=none; b=iQMaLzkY9DVlbIn3FbftQNSFXk5kPtQL2pO10xcalL+EZDVE0yu7eqmzBsgZ3C8EOujzQcgLoMW8iJZWHaX8auEmeP373615hSPO12D+dWbbW8WaJ1w3Hm+KCaT0DbHhM1bW7klvgoMEW62ooWotGFy3EQjAaqIMGT0o0b1sHKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777899578; c=relaxed/simple; bh=AkaRMWJcfZQngMfBbKjbOZI3+ub0kaJeMvKtlY7x+cw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n++GzToX0iPy09VUpIzNs8esE2Od3E97z8YzisKgEAGjnSlWU6KKxLCbvIeCcl1bDKKknNC3L6qBFkMEJuVD1VU/6g31xCXaGlnL2GQ3Zj5nk/3iGUKFhkC3h++cm/85QJbtJG3ioTLYC80oy4nrAIm/tj/09s2esGB6hToMlPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QZJrLBGv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QZJrLBGv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777899575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Z+wfwvn6biVJ4qI194NIBWVjqR1H3eW4BSETGvGmIg=; b=QZJrLBGvlCv+4qCNdb3sxJPFFsvZe3whHALxC3cH2umraaKHkjwjVtDuwA86m/ofugSeLw 6g7vFQv04JwfRVRhA3feAgI3APBjNyEwr/W1F+PoKMCqYX6DrEBazPkGvMColBgYxf2Juz qsIqYj6ZFH6OtUi1EY3ZqR/sys7v55U= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-LAUXZOfJMQagBvPmZnST8A-1; Mon, 04 May 2026 08:59:33 -0400 X-MC-Unique: LAUXZOfJMQagBvPmZnST8A-1 X-Mimecast-MFC-AGG-ID: LAUXZOfJMQagBvPmZnST8A_1777899569 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9BB431800652; Mon, 4 May 2026 12:59:28 +0000 (UTC) Received: from [10.44.32.88] (unknown [10.44.32.88]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9596E1955D84; Mon, 4 May 2026 12:59:22 +0000 (UTC) Message-ID: <40bb04ec-87a2-4e5f-9934-4ed46a731e4b@redhat.com> Date: Mon, 4 May 2026 14:59:20 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 1/2] dpll: move fractional-frequency-offset-ppt under pin-parent-device To: Jiri Pirko Cc: netdev@vger.kernel.org, Andrew Lunn , Arkadiusz Kubalewski , "David S. Miller" , Donald Hunter , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , Leon Romanovsky , Mark Bloch , Michal Schmidt , Paolo Abeni , Pasi Vaananen , Petr Oros , Prathosh Satish , Saeed Mahameed , Shuah Khan , Simon Horman , Tariq Toukan , Vadim Fedorenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org References: <20260430173611.3312596-1-ivecera@redhat.com> <20260430173611.3312596-2-ivecera@redhat.com> <290673a1-fb5b-4586-b44a-e109cc1a4629@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On 5/4/26 2:26 PM, Jiri Pirko wrote: > Mon, May 04, 2026 at 11:36:19AM +0200, ivecera@redhat.com wrote: >> Hi Jiri, >> >> On 5/4/26 10:48 AM, Jiri Pirko wrote: >>> Thu, Apr 30, 2026 at 07:36:10PM +0200, ivecera@redhat.com wrote: >>>> Move the fractional-frequency-offset-ppt attribute from the top-level >>>> pin attributes into the pin-parent-device nested attribute set. This >>>> makes it consistent with phase-offset which is already per-parent and >>>> clarifies that FFO PPT represents the frequency difference between >>>> a pin and its parent DPLL device. >>>> >>>> The top-level fractional-frequency-offset attribute (in PPM) remains >>>> unchanged for backward compatibility. >>> >>> That is odd. The ppt one was added just for higher precision but was >>> semantically the same. Now you change it. Could you still treat both the >>> same? >>> >> WDYM? >> >> Keep fractional-frequency-offset-ppt at the top-level and add both >> fractional-frequency-offset and fractional-frequency-offset-ppt into >> pin-parent-device nested attribute set? > > Since both are the same, only different unit, it would make sense to > treat them both the same. That prevents from user confusion, hopefully. > Agree... will update in v3. Thanks, Ivan