* [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask
@ 2019-01-25 10:37 Chris Mi
2019-01-25 15:54 ` David Ahern
2019-02-05 23:26 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Chris Mi @ 2019-01-25 10:37 UTC (permalink / raw)
To: netdev; +Cc: dsahern, chrism
Without this fix, the VF info can't be showed using command
"ip link".
146: ens1f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
link/ether 24:8a:07:ad:78:52 brd ff:ff:ff:ff:ff:ff
vf 0 MAC 02:25:d0:12:01:01, spoof checking off, link-state auto, trust off, query_rss off
vf 1 MAC 02:25:d0:12:01:02, spoof checking off, link-state auto, trust off, query_rss off
Fixes: d97b16b2c906 ("libnetlink: linkdump_req: Only AF_UNSPEC family expects an ext_filter_mask")
Signed-off-by: Chris Mi <chrism@mellanox.com>
---
lib/libnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index 110f47b..3beb434 100644
--- a/lib/libnetlink.c
+++ b/lib/libnetlink.c
@@ -476,7 +476,7 @@ int rtnl_linkdump_req_filter(struct rtnl_handle *rth, int family,
int rtnl_linkdump_req_filter_fn(struct rtnl_handle *rth, int family,
req_filter_fn_t filter_fn)
{
- if (family == AF_UNSPEC) {
+ if (family == AF_UNSPEC || family == AF_PACKET) {
struct {
struct nlmsghdr nlh;
struct ifinfomsg ifm;
--
2.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask
2019-01-25 10:37 [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask Chris Mi
@ 2019-01-25 15:54 ` David Ahern
2019-02-05 23:26 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2019-01-25 15:54 UTC (permalink / raw)
To: Chris Mi, netdev
On 1/25/19 3:37 AM, Chris Mi wrote:
> Without this fix, the VF info can't be showed using command
> "ip link".
>
> 146: ens1f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
> link/ether 24:8a:07:ad:78:52 brd ff:ff:ff:ff:ff:ff
> vf 0 MAC 02:25:d0:12:01:01, spoof checking off, link-state auto, trust off, query_rss off
> vf 1 MAC 02:25:d0:12:01:02, spoof checking off, link-state auto, trust off, query_rss off
>
> Fixes: d97b16b2c906 ("libnetlink: linkdump_req: Only AF_UNSPEC family expects an ext_filter_mask")
>
> Signed-off-by: Chris Mi <chrism@mellanox.com>
> ---
> lib/libnetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: David Ahern <dsahern@gmail.com>
Thanks for the fix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask
2019-01-25 10:37 [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask Chris Mi
2019-01-25 15:54 ` David Ahern
@ 2019-02-05 23:26 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2019-02-05 23:26 UTC (permalink / raw)
To: Chris Mi; +Cc: netdev, dsahern
On Fri, 25 Jan 2019 10:37:07 +0000
Chris Mi <chrism@mellanox.com> wrote:
> Without this fix, the VF info can't be showed using command
> "ip link".
>
> 146: ens1f0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
> link/ether 24:8a:07:ad:78:52 brd ff:ff:ff:ff:ff:ff
> vf 0 MAC 02:25:d0:12:01:01, spoof checking off, link-state auto, trust off, query_rss off
> vf 1 MAC 02:25:d0:12:01:02, spoof checking off, link-state auto, trust off, query_rss off
>
> Fixes: d97b16b2c906 ("libnetlink: linkdump_req: Only AF_UNSPEC family expects an ext_filter_mask")
>
> Signed-off-by: Chris Mi <chrism@mellanox.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-05 23:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25 10:37 [patch iproute2] libnetlink: linkdump_req: AF_PACKET family also expects ext_filter_mask Chris Mi
2019-01-25 15:54 ` David Ahern
2019-02-05 23:26 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).