From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D15C5AC81 for ; Fri, 18 Jan 2019 17:15:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 873972086D for ; Fri, 18 Jan 2019 17:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hQRwFPeT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbfARRPD (ORCPT ); Fri, 18 Jan 2019 12:15:03 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37615 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbfARRPD (ORCPT ); Fri, 18 Jan 2019 12:15:03 -0500 Received: by mail-pf1-f193.google.com with SMTP id y126so6904118pfb.4 for ; Fri, 18 Jan 2019 09:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=y6LjcrdhKubUfvVapShygFBrqOu51eyZSwritqIzeoY=; b=hQRwFPeTYfdir16be/pboiSe+bwnHv86/rzfIAHYu+61nhvmoyZoNNWezSOd7GcrF0 e/R26DYa8OVwBb9CcystYOH1SQdWcLJ0odQianw2JYGCOe9wLM/zQsce0qEDbg5m6xtw r4pdXvOD8Ey2/cTf7r/e35rbpxYXi5Wy+cCEphbgkCwyBEBVxG29693T0ExmQe01wV/U UicOqeFE+S/XDlB8WT2Gvh8HP+c8Rem11wwTixPETmhBAgReiv2/6+KZ+BSPHRaxZydU 6I/OedwCPCpzW4CbDFRYe73hPLg5cgmh8otQROGYkGtuLrCHg6VzXZs0VkuMNnq4Z1RO +Fpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y6LjcrdhKubUfvVapShygFBrqOu51eyZSwritqIzeoY=; b=nZwk7E7oV8iy0Tsre0rxJinkFmRz5hhhy/6oTocCcGUqehekwXnh5PcJ43bisc748g XQK9dZiYs+5WxaAdZT692FeVbz80v/qq2Psd+XYVMyKq/VcIKuPfnGpwoMr49iFP453B bOs02PrJTNNFuWmJ06VFYkpcr0Nf1oBXlswUG56xfggqLvcX/Iikv5LdRU7fc0l/dw5i itPeXGVNu9F/W5lfBqaRp1oSGmL8VaCDDvJOBZBnl+hEpV5jQJwEHHP20uRgZIBC625g cmzVUvxIqgO33ePISHZoYdORBlIOaK7GHjPvAoEsQQlbMJAqDMm3oKe3i6kWo4VYj6BJ 0iNg== X-Gm-Message-State: AJcUukctluOGHHg/l1tesyLiS8AmFx3Otm/JGxYGUc7oBi6isui5iFQz +yBnYPWUy/iT+LCdLQhkelaeBIZQ X-Google-Smtp-Source: ALg8bN7eBb+2fx7ScZpSx+ix0GvpIimAUDHVYbFjGc8FpKR4Z+IF4m1nhHIH9bN3VYrwM5EtuMOp/A== X-Received: by 2002:a63:170c:: with SMTP id x12mr18073773pgl.364.1547831702494; Fri, 18 Jan 2019 09:15:02 -0800 (PST) Received: from [192.168.86.235] (c-73-241-150-70.hsd1.ca.comcast.net. [73.241.150.70]) by smtp.gmail.com with ESMTPSA id d16sm5327726pgj.21.2019.01.18.09.15.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 09:15:00 -0800 (PST) Subject: Re: [PATCH] net: core: dev: Initialise napi state correctly To: Dave McKay , netdev@vger.kernel.org References: <20190118124632.17183-1-mckay.david@gmail.com> From: Eric Dumazet Message-ID: <40ec5737-8015-0a51-5ef5-2f4cce414500@gmail.com> Date: Fri, 18 Jan 2019 09:14:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190118124632.17183-1-mckay.david@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/18/2019 04:46 AM, Dave McKay wrote: > The state member of the napi_struct is not initialised correctly, it > sets the SCHED bit without initialising the state to zero first. This > results in peculiar behaviour if the original napi_struct didn't come > from a zero initialised region to start with. > > This patch just sets it directly using the appropriate bitfield > constant. > > Signed-off-by: Dave McKay > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 82f20022259d..250f97bf1973 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -6276,7 +6276,7 @@ void netif_napi_add(struct net_device *dev, struct napi_struct *napi, > #ifdef CONFIG_NETPOLL > napi->poll_owner = -1; > #endif > - set_bit(NAPI_STATE_SCHED, &napi->state); > + napi->state = NAPIF_STATE_SCHED; > napi_hash_add(napi); > } > EXPORT_SYMBOL(netif_napi_add); > I am curious, which driver has exhibit any issue with current code ? Thanks.