* Re: [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware
[not found] <200407221027.33023.margitsw@t-online.de>
@ 2004-07-22 10:42 ` Luis R. Rodriguez
2004-07-27 16:26 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Luis R. Rodriguez @ 2004-07-22 10:42 UTC (permalink / raw)
To: Margit Schubert-While; +Cc: jgarzik, netdev, prism54-devel
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On Thu, Jul 22, 2004 at 10:27:32AM +0200, Margit Schubert-While wrote:
> 2004-07-22 Margit Schubert-While <margitsw@t-online.de>
>
> * In the card initialization routine, we try to set the
> output power. For firmware < 1.0.4.3, this leads to a
> worrying "mgt_commit has failed .." in the log although
> the device continues to react normally.
> Fix is simple, do not try to configure output power.
> (which I believe we should not be doing anyway as it is
> probably against local country regulations)
>
> Margit
Margit, I think we should rather detect the version of the firmware and
depending on this decide what to do.
A quick test proves you can obtain firmware verion from
[OID_INL_VERSION] = {0xFF020005, 0, 8, OID_TYPE_RAW},
Then somewhere,
union oid_res_t r;
char *ver;
mgt_get_request(priv, OID_INL_VERSION, 0, NULL, &r);
ver = (char *) r.ptr;
printk(KERN_DEBUG "Version: %s\n", ver);
This will either be 1.0.4.3.arm or 1.0.3.0.arm. You can then strcmp and
do the right thing. I'd finish this work up but I'm busy with WPA.
Luis
--
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware
[not found] <200407221027.33023.margitsw@t-online.de>
2004-07-22 10:42 ` [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware Luis R. Rodriguez
@ 2004-07-27 16:26 ` Jeff Garzik
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2004-07-27 16:26 UTC (permalink / raw)
To: Margit Schubert-While; +Cc: netdev, prism54-devel
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware
@ 2004-07-27 17:26 Margit Schubert-While
2004-07-27 18:14 ` Jeff Garzik
0 siblings, 1 reply; 5+ messages in thread
From: Margit Schubert-While @ 2004-07-27 17:26 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, prism54-devel
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
Regardless of Luis's comments, we should not try to tamper with this.
Please apply.
Forthcoming fixes may well be able to do better. However, until
more information is known, the fix is correct.
The version OID will be evaluated in a later fix (for info only).
Margit
[-- Attachment #2: outputpow.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]
diff -Naur linux-2.6.8-01/drivers/net/wireless/prism54/oid_mgt.c linux-2.6.8-04/drivers/net/wireless/prism54/oid_mgt.c
--- linux-2.6.8-01/drivers/net/wireless/prism54/oid_mgt.c 2004-07-15 17:21:42.000000000 +0200
+++ linux-2.6.8-04/drivers/net/wireless/prism54/oid_mgt.c 2004-07-22 09:50:20.000000000 +0200
@@ -613,7 +613,9 @@
DOT11_OID_DEFKEYID,
DOT11_OID_DOT1XENABLE,
OID_INL_DOT11D_CONFORMANCE,
+ /* Do not initialize this - fw < 1.0.4.3 rejects it
OID_INL_OUTPUTPOWER,
+ */
};
/* update the MAC addr. */
[-- Attachment #3: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Prism54-devel mailing list
Prism54-devel@prism54.org
http://prism54.org/mailman/listinfo/prism54-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware
@ 2004-07-22 8:27 Margit Schubert-While
0 siblings, 0 replies; 5+ messages in thread
From: Margit Schubert-While @ 2004-07-22 8:27 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, prism54-devel
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
2004-07-22 Margit Schubert-While <margitsw@t-online.de>
* In the card initialization routine, we try to set the
output power. For firmware < 1.0.4.3, this leads to a
worrying "mgt_commit has failed .." in the log although
the device continues to react normally.
Fix is simple, do not try to configure output power.
(which I believe we should not be doing anyway as it is
probably against local country regulations)
Margit
[-- Attachment #2: outputpow.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]
diff -Naur linux-2.6.8-01/drivers/net/wireless/prism54/oid_mgt.c linux-2.6.8-04/drivers/net/wireless/prism54/oid_mgt.c
--- linux-2.6.8-01/drivers/net/wireless/prism54/oid_mgt.c 2004-07-15 17:21:42.000000000 +0200
+++ linux-2.6.8-04/drivers/net/wireless/prism54/oid_mgt.c 2004-07-22 09:50:20.000000000 +0200
@@ -613,7 +613,9 @@
DOT11_OID_DEFKEYID,
DOT11_OID_DOT1XENABLE,
OID_INL_DOT11D_CONFORMANCE,
+ /* Do not initialize this - fw < 1.0.4.3 rejects it
OID_INL_OUTPUTPOWER,
+ */
};
/* update the MAC addr. */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-07-27 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200407221027.33023.margitsw@t-online.de>
2004-07-22 10:42 ` [PATCH Linux-2.6.8-rc1] prism54 Fix initialization with older firmware Luis R. Rodriguez
2004-07-27 16:26 ` Jeff Garzik
2004-07-27 17:26 Margit Schubert-While
2004-07-27 18:14 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-07-22 8:27 Margit Schubert-While
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).