netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bertrand Guay-Paquet <bernie@step.polymtl.ca>
To: netdev@oss.sgi.com
Subject: skb_clone slower than copying skb data
Date: Mon, 02 Aug 2004 10:13:42 -0400	[thread overview]
Message-ID: <410E4C16.6070604@step.polymtl.ca> (raw)

Hello,

I am writing a patch for the usbnet driver to add support for the 
Prolific PL2501 USB host-to-host cable. My question is entirely related 
to netdev business however, so please read on.

In order to achieve Win32 interropability, the driver needs to receive 
up to 6 ethernet packets wrapped up in a single skb. My current 
implementation for reading the contained individual packets is: 
(simplified to show relevant parts)

for (each packet in skb except last one) {
	length = packet_length();

	if (!(skb2 = alloc_skb(length, GFP_ATOMIC)))
		return -ENOMEM;

	//Copy the data related to the current ethernet packet
	memcpy(skb_put(skb2, length), skb->data, length);

	//Jump to next ethernet packet
	skb_pull(skb, length);
	netif_rx(skb2);
}
//Process last packet
netif_rx(skb);
==========

This works very well but uses unnecessary memory for the memcpy. I then 
tried: (again simplified to show relevant parts):

for (each packet in skb except last one) {
	length = packet_length();

	if (!(skb2 = skb_clone(skb, GFP_ATOMIC)))
		return -ENOMEM;

	//Copy the data related to the current ethernet packet
	skb_trim(skb2, length);

	//Jump to next ethernet packet
	skb_pull(skb, length);
	netif_rx(skb2);
}
//Process last packet
netif_rx(skb);
==========

This works as well, but the throughput is cut in half. How can this be 
so? Is skb_clone combined with netif_rx supposed to be so slow? I have 
searched other uses of skb_clone and have not found any similar to mine 
so I do not know if this is normal behaviour or not. I have tried using 
skb_clone with 2.4.26 and 2.6.7 with the same results.

Any help would be greatly appreciated!

Bertrand

                 reply	other threads:[~2004-08-02 14:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410E4C16.6070604@step.polymtl.ca \
    --to=bernie@step.polymtl.ca \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).