From: Kazunori Miyazawa <kazunori@miyazawa.org>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: davem@redhat.com, herbert@gondor.apana.org.au,
netdev@oss.sgi.com, usagi-core@linux-ipv6.org
Subject: Re: [PATCH][IPv6] separation xfrm_lookup from ip6_dst_lookup
Date: Tue, 03 Aug 2004 18:21:10 +0900 [thread overview]
Message-ID: <410F5906.30402@miyazawa.org> (raw)
In-Reply-To: <20040803.020015.44364045.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki wrote:
> In article <20040801195135.16734846.davem@redhat.com> (at Sun, 1 Aug 2004 19:51:35 -0700), "David S. Miller" <davem@redhat.com> says:
>
>
>>On Fri, 30 Jul 2004 17:12:05 +0900
>>Kazunori Miyazawa <kazunori@miyazawa.org> wrote:
>>
>>
>>>I consider copying flowi(fl_rt) uses too much stack at the moment.
>>>I'll re-send the fixed patch again.
>>
>>I agree, and let's defer this patch until we
>>resolve that.
>
>
> Is the overhead for allocating memory okay?
> Or, do we allcoate some per-cpu memory while ipv6.o initalization phase?
> (check: lock? preemption?)
> Or, will we allocate fl (and fl_rt) per sock{} (ipv6_pinfo{})?
> (ditto.)
>
My intention is not high art, just using struct in6_addr
instead of struct flowi to store final destination.
> We have similar stack usage in other codes, and
> I would fix them at the same time.
>
These might be my changes. I will fix them.
>
> Another question just for future reference:
> how many bytes (approx.) do we accept on stack?
>
> Note: sizeof(struct flowi) is 72 bytes (on i386)
>
> --yoshfuji
--Kazunori Miyazawa
next prev parent reply other threads:[~2004-08-03 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 8:12 [PATCH][IPv6] separation xfrm_lookup from ip6_dst_lookup Kazunori Miyazawa
2004-08-02 2:51 ` David S. Miller
2004-08-03 9:00 ` YOSHIFUJI Hideaki / 吉藤英明
2004-08-03 9:21 ` Kazunori Miyazawa [this message]
2004-08-09 23:35 ` David S. Miller
2004-08-10 1:38 ` YOSHIFUJI Hideaki / 吉藤英明
2004-08-27 16:49 ` [PATCH, TAKE 2] [IPV6] XFRM: extract xfrm_lookup() from ip6_dst_lookup() (is Re: [PATCH][IPv6] separation xfrm_lookup from ip6_dst_lookup) YOSHIFUJI Hideaki / 吉藤英明
2004-08-28 0:02 ` David S. Miller
2004-10-25 21:27 ` Brian Haley
2004-10-26 3:55 ` YOSHIFUJI Hideaki / 吉藤英明
2004-10-26 14:29 ` Brian Haley
2004-10-26 15:43 ` YOSHIFUJI Hideaki / 吉藤英明
2004-10-26 18:09 ` Brian Haley
2004-10-27 0:10 ` YOSHIFUJI Hideaki / 吉藤英明
2004-10-27 15:21 ` Brian Haley
2004-08-02 7:41 ` [PATCH][IPv6] separation xfrm_lookup from ip6_dst_lookup Herbert Xu
2004-08-03 2:09 ` David S. Miller
2004-08-03 8:19 ` YOSHIFUJI Hideaki / 吉藤英明
2004-08-03 10:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410F5906.30402@miyazawa.org \
--to=kazunori@miyazawa.org \
--cc=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
--cc=usagi-core@linux-ipv6.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).